Skip to content

Commit

Permalink
Get rid of obsolete Make variable TARGET_CORE_JARS.
Browse files Browse the repository at this point in the history
Test: aosp_walleye-userdebug boots.
Test: art/test/testrunner/testrunner.py --target --64
Test: art/tools/run-gtests.sh -j4
Test: art/test.py --host -r

Bug: 147579140

Change-Id: Iab4d4c7f875773c0141688dc681b9abb37010264
Merged-In: Iab4d4c7f875773c0141688dc681b9abb37010264
(cherry picked from commit d8cdd4e)
  • Loading branch information
Ulya Trafimovich authored and TreeHugger Robot committed Mar 24, 2020
1 parent 4b7a6bf commit c0f7221
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Android.mk
Original file line number Diff line number Diff line change
Expand Up @@ -750,7 +750,7 @@ build-art-host-golem: build-art-host \
########################################################################
# Phony target for building what go/lem requires for syncing /system to target.
.PHONY: build-art-unbundled-golem
build-art-unbundled-golem: art-runtime linker oatdump $(TARGET_CORE_JARS) crash_dump
build-art-unbundled-golem: art-runtime linker oatdump $(ART_APEX_JARS) conscrypt crash_dump

########################################################################
# Rules for building all dependencies for tests.
Expand Down
6 changes: 2 additions & 4 deletions tools/build/var_cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
#
# For example, this would be a valid var-cache:
#
# export ART_TOOLS_BUILD_VAR_CACHE="TARGET_CORE_JARS='core-oj core-libart'
# HOST_CORE_JARS='core-oj-hostdex core-libart-hostdex'"
# export ART_TOOLS_BUILD_VAR_CACHE="ART_APEX_JARS='core-oj core-libart'"
#
# Calling into soong repeatedly is very slow; whenever it needs to be done
# more than once, the var_cache.py or var_cache.sh script should be used instead.
Expand Down Expand Up @@ -119,8 +118,7 @@ def _build_dict():
_var_cache_dict = {}

# Parse $ART_TOOLS_BUILD_VAR_CACHE, e.g.
# TARGET_CORE_JARS='core-oj core-libart conscrypt okhttp bouncycastle apache-xml'
# HOST_CORE_JARS='core-oj-hostdex core-libart-hostdex ...'
# ART_APEX_JARS='core-oj core-libart conscrypt okhttp bouncycastle apache-xml'

for line in os.environ['ART_TOOLS_BUILD_VAR_CACHE'].splitlines():
_debug(line)
Expand Down
6 changes: 2 additions & 4 deletions tools/build/var_cache.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
#
# For example, this would be a valid var-cache:
#
# export ART_TOOLS_BUILD_VAR_CACHE="TARGET_CORE_JARS='core-oj core-libart'
# HOST_CORE_JARS='core-oj-hostdex core-libart-hostdex'"
# export ART_TOOLS_BUILD_VAR_CACHE="ART_APEX_JARS='core-oj core-libart'"
#
# Calling into soong repeatedly is very slow; whenever it needs to be done
# more than once, the var_cache.py or var_cache.sh script should be used instead.
Expand Down Expand Up @@ -124,8 +123,7 @@ _var_cache_build_dict() {
fi

# Parse $ART_TOOLS_BUILD_VAR_CACHE, e.g.
# TARGET_CORE_JARS='core-oj core-libart conscrypt okhttp bouncycastle apache-xml'
# HOST_CORE_JARS='core-oj-hostdex core-libart-hostdex ...'
# ART_APEX_JARS='core-oj core-libart conscrypt okhttp bouncycastle apache-xml'

local var_name
local var_value
Expand Down
3 changes: 1 addition & 2 deletions tools/build/var_list
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@
#

# javac-helper.sh
TARGET_CORE_JARS
ART_APEX_JARS
PRODUCT_BOOT_JARS
TARGET_OUT_COMMON_INTERMEDIATES
HOST_CORE_JARS
HOST_OUT_COMMON_INTERMEDIATES

# testrunner/env.py
Expand Down

0 comments on commit c0f7221

Please sign in to comment.