Cleanup of startMZmine_Windows.bat #50
Conversation
| :: ***************************************** | ||
|
|
||
| :: Total amount of memory in MB available to MZmine 2. | ||
| :: 0 = automatically determined |
There was a problem hiding this comment.
the comment says 0 = automatically determined, but below AUTO is used instead of 0.
|
I am not 100% sure about this line: |
startMZmine_MacOSX.command
|
The -eq AUTO is not going to work, because -eq is used to compare integers: The = operator might be better: But you'll need to add parenthesis around AUTO. |
|
|
||
| :: It is usually not necessary to modify the JAVA_COMMAND parameter, but if you like to run | ||
| :: a specific Java Virtual Machine, you may set the path to the java command of that JVM | ||
| set JAVA_COMMAND=java |
There was a problem hiding this comment.
Since you're cleaning up the scripts, maybe we could change this to
JAVA_COMMAND=java.exe
in the Windows script. That will make the meaning more obvious. The comment can be also updated ("..., you may set the path to the java.exe command...").
|
I changed the comparison to: |
| echo "Checking physical memory size..." | ||
| TOTAL_MEMORY=`free -b | awk '/Mem:/ { print int($2 / 1024^2) }'` | ||
| echo "Found $TOTAL_MEMORY MB memory" | ||
|
|
||
| if [ "$TOTAL_MEMORY" -gt 4096 ]; then | ||
| if [ "$HEAP_SIZE" == "AUTO" ]; then |
There was a problem hiding this comment.
Hi Thomas,
I think it should be a single equal sign (=), not ==.
As I posted in the previous message:
s1 = s2 True if the strings s1 and s2 are identical.
Cleanup of startMZmine_Windows.bat
Please comment on the changes I have made to the Windows script. Once we are happy with it, I will make the same changes to the linux ans mac scripts and you can then also comment on them.