Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XLSX Excel spreadsheet analyzer #8045

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add XLSX Excel spreadsheet analyzer #8045

merged 1 commit into from
Dec 13, 2023

Conversation

gbp
Copy link
Member

@gbp gbp commented Dec 12, 2023

Relevant issue(s)

Connected to #2663

What does this do?

Add Excel spreadsheet analyzer

Why was this needed?

This is an initial step to detect hidden data in spreadsheet.

Implementation notes

Attachments are stored in ActiveStorage so we are using Analyzers which runs automatically when file blobs are uploaded.

Copy link
Collaborator

@mdeuk mdeuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive the interruption - I've pushed a couple of suggestions to replace XSLX with XLSX 1.

Footnotes

  1. super easy mistake, those extensions are a bit of a nuisance.

gems/excel_analyzer/README.md Outdated Show resolved Hide resolved
gems/excel_analyzer/spec/excel_analyzer/analyzer_spec.rb Outdated Show resolved Hide resolved
gems/excel_analyzer/spec/excel_analyzer/analyzer_spec.rb Outdated Show resolved Hide resolved
gems/excel_analyzer/spec/excel_analyzer/analyzer_spec.rb Outdated Show resolved Hide resolved
gems/excel_analyzer/lib/excel_analyzer/analyzer.rb Outdated Show resolved Hide resolved
@gbp gbp force-pushed the excel-analyzer branch 4 times, most recently from fe210c7 to 983a576 Compare December 13, 2023 12:33
Attachments are stored in `ActiveStorage` so we are using analyzers
which run automatically when file blobs are uploaded.

This is an initial step to detect hidden data in spreadsheet.
@gbp gbp marked this pull request as ready for review December 13, 2023 15:10
@gbp gbp merged commit 17a3fcd into develop Dec 13, 2023
8 checks passed
@garethrees garethrees changed the title Add Excel spreadsheet analyzer Add XLSX Excel spreadsheet analyzer Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants