Add company to client #79

icaroang · 2019-09-20T20:28:43Z

Story details: https://app.clubhouse.io/nexaas/story/23789

houndci-bot · 2019-09-20T20:28:49Z

spec/cobrato/resources/company_spec.rb

+      VCR.use_cassette("companies/create/success") do
+        company = subject.create(params)
+        expect(company).to be_a(entity_klass)
+        expect(company.name).to eq(params['name'])


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-20T20:28:50Z

spec/cobrato/resources/company_spec.rb

+  describe "#update" do
+    it "returns a Company instance updated" do
+      VCR.use_cassette("companies/update/success") do
+        company = subject.update(227, {name: "RSpec integration"})


Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2019-09-20T20:28:50Z

spec/cobrato/resources/company_spec.rb

@@ -0,0 +1,77 @@
+require "spec_helper"
+
+describe Cobrato::Resources::Company do


Metrics/BlockLength: Block has too many lines. [66/25]

houndci-bot · 2019-09-20T20:28:50Z

spec/cobrato/resources/company_spec.rb

@@ -0,0 +1,77 @@
+require "spec_helper"


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-09-20T20:28:50Z

spec/cobrato/entities/company_spec.rb

+
+  subject { described_class.new(attributes) }
+
+  it_behaves_like "entity_attributes", [:id, :national_identifier_type, :national_identifier, :name, :zipcode, :city, :state, :neighbourhood, :number, :complement, :street]


Style/SymbolArray: Use %i or %I for an array of symbols.
Metrics/LineLength: Line is too long. [172/120]

houndci-bot · 2019-09-20T20:28:51Z

spec/cobrato/entities/company_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-09-20T20:28:51Z

lib/cobrato/resources/company.rb

+      end
+    end
+  end
+end


Layout/TrailingBlankLines: Final newline missing.

houndci-bot · 2019-09-20T20:28:52Z

lib/cobrato/resources/company.rb

@@ -0,0 +1,13 @@
+module Cobrato


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-09-20T20:28:52Z

lib/cobrato/entities/company.rb

+      attribute :street,                   String
+    end
+  end
+end


Layout/TrailingBlankLines: Final newline missing.

houndci-bot · 2019-09-20T20:28:52Z

lib/cobrato/entities/company.rb

@@ -0,0 +1,17 @@
+module Cobrato


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-09-20T21:38:17Z

spec/cobrato/entities/payment_spec.rb

  it_behaves_like "entity_attributes",
    [
      # Shared with all
      :id, :payment_config_id, :payment_type, :payment_method, :amount, :date, :registration_status, :our_number,
-      :bank_code, :payee_document_type, :payee_document, :payee_name, :note,
+      :bank_code, :payee_document_type, :payee_document, :payee_name, :note, :company_document_type, :company_document, :company_name,


Metrics/LineLength: Line is too long. [134/120]

houndci-bot · 2019-09-20T21:38:17Z

spec/cobrato/entities/payment_spec.rb

+
+  describe '#payee_document_type' do
+    it 'print a deprecation warning' do
+      expect {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2019-09-20T21:38:17Z

spec/cobrato/entities/payment_spec.rb

+  end
+
+  describe '#payee_document_type' do
+    it 'print a deprecation warning' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-20T21:38:17Z

spec/cobrato/entities/payment_spec.rb

+    end
+  end
+
+  describe '#payee_document_type' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-20T21:38:18Z

spec/cobrato/entities/payment_spec.rb

+
+  describe '#payee_document' do
+    it 'print a deprecation warning' do
+      expect {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2019-09-20T21:38:19Z

spec/cobrato/entities/payment_spec.rb

@@ -61,15 +65,47 @@

  subject { described_class.new(attributes) }

+  describe '#payee_id' do
+    it 'print a deprecation warning' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-20T21:38:19Z

spec/cobrato/entities/payment_spec.rb

@@ -61,15 +65,47 @@

  subject { described_class.new(attributes) }

+  describe '#payee_id' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-20T21:38:19Z

spec/cobrato/entities/charge_config_spec.rb

@@ -29,9 +30,17 @@

  subject { described_class.new(attributes) }

+  describe '#payee_id' do
+    it 'print a deprecation warning' do
+      expect {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2019-09-20T21:38:19Z

spec/cobrato/entities/charge_config_spec.rb

@@ -29,9 +30,17 @@

  subject { described_class.new(attributes) }

+  describe '#payee_id' do
+    it 'print a deprecation warning' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-20T21:38:19Z

spec/cobrato/entities/charge_config_spec.rb

@@ -29,9 +30,17 @@

  subject { described_class.new(attributes) }

+  describe '#payee_id' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-23T12:59:29Z

spec/cobrato/resources/company_spec.rb

+  describe "#update" do
+    it "returns a Company instance updated" do
+      VCR.use_cassette("companies/update/success") do
+        company = subject.update(227, { name: "RSpec integration" })


Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/resources/company_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+require "spec_helper"


Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/entities/company_spec.rb

+
+  subject { described_class.new(attributes) }
+
+  it_behaves_like "entity_attributes", %i[id national_identifier_type national_identifier name zipcode city state neighbourhood number complement street]


Metrics/LineLength: Line is too long. [153/120]

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/entities/company_spec.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+require "spec_helper"


Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/entities/bank_account_spec.rb

+    end
+  end
+
+  it_behaves_like "entity_attributes", [:id, :payee_id, :company_id, :bank_code, :agency_digit, :agency, :account, :account_digit]


Style/SymbolArray: Use %i or %I for an array of symbols.
Metrics/LineLength: Line is too long. [130/120]

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/entities/bank_account_spec.rb

-  it_behaves_like "entity_attributes", [:id, :payee_id, :bank_code, :agency_digit, :agency, :account, :account_digit]
+  describe '#payee_id' do
+    it 'print a deprecation warning' do
+      expect {


Style/BlockDelimiters: Avoid using {...} for multi-line blocks.

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/entities/bank_account_spec.rb

@@ -14,5 +15,13 @@

  subject { described_class.new(attributes) }

-  it_behaves_like "entity_attributes", [:id, :payee_id, :bank_code, :agency_digit, :agency, :account, :account_digit]
+  describe '#payee_id' do
+    it 'print a deprecation warning' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2019-09-23T12:59:30Z

spec/cobrato/entities/bank_account_spec.rb

@@ -14,5 +15,13 @@

  subject { described_class.new(attributes) }

-  it_behaves_like "entity_attributes", [:id, :payee_id, :bank_code, :agency_digit, :agency, :account, :account_digit]
+  describe '#payee_id' do


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Add company resource to client

26dd09d

icaroang added the wip label Sep 20, 2019

icaroang self-assigned this Sep 20, 2019

houndci-bot reviewed Sep 20, 2019

View reviewed changes

Add company attributes to resources

1c422b9

houndci-bot reviewed Sep 20, 2019

View reviewed changes

icaroang changed the title ~~[WIP] Add company to client~~ Add company to client Sep 20, 2019

icaroang assigned icaroang and unassigned icaroang Sep 20, 2019

icaroang requested a review from jcomello September 20, 2019 21:42

icaroang added review and removed wip labels Sep 20, 2019

Small fixes

b5e95b9

houndci-bot reviewed Sep 23, 2019

View reviewed changes

More fixes

88ba49c

jcomello approved these changes Sep 23, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add company to client #79

Add company to client #79

icaroang commented Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 20, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

houndci-bot Sep 23, 2019

		@@ -0,0 +1,77 @@
		require "spec_helper"

		describe Cobrato::Resources::Company do


		subject { described_class.new(attributes) }

		it_behaves_like "entity_attributes", [:id, :national_identifier_type, :national_identifier, :name, :zipcode, :city, :state, :neighbourhood, :number, :complement, :street]

		@@ -61,15 +65,47 @@

		subject { described_class.new(attributes) }

		describe '#payee_id' do

		@@ -29,9 +30,17 @@

		subject { described_class.new(attributes) }

		describe '#payee_id' do

		@@ -0,0 +1,78 @@
		# frozen_string_literal: true
		require "spec_helper"


		subject { described_class.new(attributes) }

		it_behaves_like "entity_attributes", %i[id national_identifier_type national_identifier name zipcode city state neighbourhood number complement street]

		@@ -0,0 +1,23 @@
		# frozen_string_literal: true
		require "spec_helper"

Add company to client #79

Are you sure you want to change the base?

Add company to client #79

Conversation

icaroang commented Sep 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment