Fix code scanning alert no. 4: Resolving XML external entity in user-controlled data #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mybatis/ibatis-2/security/code-scanning/4
To fix the problem, we need to ensure that the XML parser is fully secured against XXE attacks by explicitly disabling external entity resolution. This involves setting the appropriate features on the
DocumentBuilderFactory
to prevent the parser from resolving external entities.createDocument
method inNodeletParser
to disable external entity resolution.DocumentBuilderFactory
to ensure that external entities are not processed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.