Merge pull request #258 from mybatis/autofix/alert-3-60a2799539

Fix code scanning alert no. 3: Resolving XML external entity in user-controlled data
mybatis · Sep 26, 2024 · ba20fd0 · ba20fd0
2 parents b80acbe + 849e99d
commit ba20fd0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/main/java/com/ibatis/common/xml/NodeletParser.java b/src/main/java/com/ibatis/common/xml/NodeletParser.java
@@ -197,6 +197,8 @@ private Document createDocument(Reader reader)
       throws ParserConfigurationException, FactoryConfigurationError, SAXException, IOException {
     DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
     factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
+     factory.setFeature("http://xml.org/sax/features/external-general-entities", false);
+    factory.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
     factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, "");
     factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "");
     factory.setValidating(validation);