Add custom docstring sections for hardware objects

[fabcor-maxiv]

No description provided.

[fabcor-maxiv]

This adds two custom docstring sections:

• Emits
• Hardware object properties

I believe there is some "bikeshedding" to be made:

• the names are inconsistent, I feel like we should get rid of the Hardware object prefix.
• I do not know if Properties is the best choice of word here
• Maybe Emits could be replaces by Signals

The Emits was actually introduced in #866 which is not merged yet (cc @meguiraun, see below).

The Hardware object properties was requested by @elmjag for a change that is not in GitHub (yet), and I believe it is a good idea.

@meguiraun for info, I also reused the AbstractActuator changes that you made in #866 as base for an example on how to use these in docstrings. But now, this might cause merge conflict...

You can preview how it renders at:

• https://mxcubecore--947.org.readthedocs.build/en/947/dev/autosummary/mxcubecore.HardwareObjects.abstract.AbstractActuator.html
• https://mxcubecore--947.org.readthedocs.build/en/947/dev/docs.html#more-details-about-documentation-system

[marcus-oscarsson]

Nice, we should be careful with the Hardware object properties because the configuration will be defined by a Pydantic model and the properties accessed via .config or directly via the hardware object it self (if its a role). In this case the Hardware object properties would be on the configuration object I guess.

I don't mind if we add this in the mean time, but it does mean that we will, probably, need to change it later.

[fabcor-maxiv]

Nice, we should be careful with the Hardware object properties because the configuration will be defined by a Pydantic model and the properties accessed via .config or directly via the hardware object it self (if its a role). In this case the Hardware object properties would be on the configuration object I guess.

I don't mind if we add this in the mean time, but it does mean that we will, probably, need to change it later.

Right... I did not have the Pydantic story fully in mind. I am still not clear on how it will look like. But maybe with the Pydantic models, it will be self-documenting somehow... I do not know. I would be interested in seeing concrete examples.

I guess I do not mind changing it back to something else when it is time, and anyway I doubt anyone will have time/energy to write many such docstrings before the migration : D

[rhfogh]

I agree with @marcus-oscarsson

[marcus-oscarsson]

Its still a very preliminary draft but it would/could look something like this:

mxcubecore/mxcubecore/HardwareObjects/abstract/AbstractDetector.py

Line 66 in 8ba39dc

HOConfig = AbstractDetectorConfiguration

The model could be better specified through Field and given a description as well (which is not yet the case in the example). So it is indeed to a certain extent self describing but one could of course imagine a class level documentation of the model.

mxcubecore/mxcubecore/model/configmodel.py

Line 29 in 8ba39dc

class AbstractDetectorConfiguration(BaseModel): # , extra=Extra.forbid):

[fabcor-maxiv]

Seems like this could help, looks promising: https://pypi.org/project/autodoc_pydantic/

I close this pull request for now.

[marcus-oscarsson]

Wow, thats seems nice. I think the emit documentation is still very nice though !

[fabcor-maxiv]

I think the emit documentation is still very nice though !

I will try to take over #866 then, that would make more sense.

[marcus-oscarsson]

Ok

[fabcor-maxiv]

Done in #1116.