Replace python-ldap with openldap in conda env #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me |
fabcor-maxiv
force-pushed
the
conda-python-ldap
branch
from
ba76efc to
1b908ca
Compare
|
I updated the comment, I think it is more accurate like this. |
|
@fabcor-maxiv, thanks could you please rebase ? |
On PyPI, `python-ldap` is distributed as an *sdist* only, not *wheel*. But it still requires a compilation step before installation. Some dependencies installed with conda are rightfully ignored by Poetry. Even when `python-ldap` is pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed: * <python-poetry/poetry#6408 (comment)> * <conda-forge/python-ldap-feedstock#28> So it does not make much sense to let conda install `python-ldap`. Instead we can instruct conda to install `openldap` only, and pip and Poetry should be able to compile `python-ldap`. GitHub: mxcube/mxcubeweb#1510 GitHub: mxcube#849 (comment) GitHub: conda-forge/python-ldap-feedstock#28 GitHub: mxcube#851
fabcor-maxiv
force-pushed
the
conda-python-ldap
branch
from
1b908ca to
3f77698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PyPI,
python-ldapis distributed as an sdist only, not wheel. But it still requires a compilation step before installation.Some dependencies installed with conda are rightfully ignored by Poetry. Even when
python-ldapis pre-installed by conda, Poetry would still need to reinstall it which implies compilation. Indeed there is an issue in how conda packages are created and how they are installed:direct_url.jsonfile conda-forge/python-ldap-feedstock#28So it does not make much sense to let conda install
python-ldap. Instead we can instruct conda to installopenldaponly, and pip and Poetry should be able to compilepython-ldap.GitHub: mxcube/mxcubeweb#1510
GitHub: #849 (comment)
GitHub: conda-forge/python-ldap-feedstock#28
GitHub: #851