Android support #1352
Merged
Android support #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! ci for android fails |
The failure is: It passed in my fork's CI run, and I suspect that if you re-ran the workflow once or twice that it would work for you. I think the problem is just that the Android emulator is slow, so timing tests like these need a little more padding. I could bump up the test tolerance (perhaps just for Android) in places like https://github.com/mxcl/PromiseKit/blob/master/Tests/CorePromise/AfterTests.swift#L40C29-L40C36 if you think that would be OK? |
|
Oh ok, that's fine. I'll merge and fix the CI stuff separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Android, as well as a CI action to run the unit tests against an Android emulator.