Don't build netifaces wheel on pip parse #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvukov
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
LGTM, though I would've chosen ifaddr as it's a pure python impl. I guess you wanted to be in sync with from ros2/ros2cli#875.
| - <exec_depend>python3-netifaces</exec_depend> | ||
| <exec_depend>python3-packaging</exec_depend> | ||
| <exec_depend>python3-pkg-resources</exec_depend> | ||
| + <exec_depend>python3-psutil</exec_depend> |
There was a problem hiding this comment.
Oh, well, we don't need this, but I guess you wanted to recycle the patch from ros2/ros2cli#875.
|
btw, psutil binaries are only for amd64. I guess you don't need e.g. arm64 at the moment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ros2/ros2cli#875 as a patch.
netifaces is unmaintained: al45tair/netifaces#78.
It does not provide official prebuilt wheels for Python > 3.9: https://pypi.org/project/netifaces/#files
We don't have a non-bazel host compiler so building that Python wheel is difficult in our CI.