feat: implement MUXSDKMonitor API and switch MUXSDKStats to use it #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
force-pushed
the
ajlb/feat/implement-new-API-and-switch-MUXSDKStats-to-use-it
branch
from
ae02bd6 to
b72be62
Compare
andrewjl-mux
force-pushed
the
ajlb/feat/expose-new-monitoring-api
branch
from
5356a2f to
e7c7263
Compare
andrewjl-mux
force-pushed
the
ajlb/feat/implement-new-API-and-switch-MUXSDKStats-to-use-it
branch
6 times, most recently
from
94c10ea to
6676c0b
Compare
andrewjl-mux
commented
Nov 3, 2023
| [player didTriggerManualVideoChange]; | ||
| [player dispatchViewEnd]; | ||
|
|
||
| // FIXME: Previous implementation did a nil check |
There was a problem hiding this comment.
I think this change is safe, MUXSDKDataEvent properties default to nil so skipping a nil check gets the same result.
andrewjl-mux
commented
Nov 3, 2023
| MUXSDKCustomerViewData *viewData = customerData.customerViewData; | ||
| MUXSDKCustomData *customData = customerData.customData; | ||
|
|
||
| [_customerPlayerDataStore setPlayerData:playerData |
There was a problem hiding this comment.
Prior implementation didn't check playerData for nil, kept the same distinction here.
andrewjl-mux
commented
Nov 3, 2023
| @@ -20,206 +14,19 @@ | |||
|
|
|||
| @implementation MUXSDKStats | |||
|
|
|||
| static MUXSDKDispatcher *_dispatcher; | |||
There was a problem hiding this comment.
This _dispatcher was unused, so removed it completely.
andrewjl-mux
commented
Nov 3, 2023
| @@ -1,12 +1,6 @@ | |||
| #import "MUXSDKStats.h" | |||
| #import "MUXSDKConstants.h" | |||
There was a problem hiding this comment.
The logic in this file has been effectively moved to MUXSDKMonitor.m, some parts got removed completely as part of the clean-up.
andrewjl-mux
commented
Nov 3, 2023
| return environmentData; | ||
| } | ||
|
|
||
| + (MUXSDKViewerData *)buildViewerData { |
There was a problem hiding this comment.
The logic in buildViewerData has been extracted out to a separate MUXSDKPlaceholderViewerData class.
Base automatically changed from
ajlb/feat/expose-new-monitoring-api
to
releases/v4.0.0
November 3, 2023 18:25
andrewjl-mux
force-pushed
the
ajlb/feat/implement-new-API-and-switch-MUXSDKStats-to-use-it
branch
5 times, most recently
from
4f2e527 to
3ae162e
Compare
centralize MUXSDKCore parameter passing refactor: move placeholder viewer data retrieval out of MUXSDKMonitor feat: implement rest of the MUXSDKMonitor stubs and clean-up binding manager Clean-up MUXSDKStats declarations refactor: convert MUXSDKStats to use MUXSDKMonitor internally
andrewjl-mux
force-pushed
the
ajlb/feat/implement-new-API-and-switch-MUXSDKStats-to-use-it
branch
from
0377912 to
4dfd253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional minor clean-up, mostly internal-only renames.