-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Strings Github Action #129
base: master
Are you sure you want to change the base?
Conversation
We cannot always wait for translators for every string addition. We do not have translators for all languages that are constantly standing waiting. We can hire translators only maybe once per year. Can we instead use the following workflow?
|
@jermy-c Can you please make a new PR which implements the above workflow? Steps 1-5 above should be a single Github action. |
More concretely, steps 1, 2, 3 and 5 should each have their own commands in packages.json. Then, another packages.json command should do steps 1-3 and 5 (but not the step 4 commit) together. Lastly, a github action invokes that command, and then makes the git commit, as done here in this PR. This allows us to do things either manually on the local machine, or via GitHub Actions. (UPDATE: Typo of step numbers corrected.) |
Sounds good, will do. |
Changes
Proposed workflow
Extract Strings
, this leaves extracted strings empty so it's safe to have them in themaster
branchAutomatically translated
and marked asNeeds editing
Automatically translated
label andNeeds editing
are automatically removedtranslations
branchmaster