Skip to content

Commit

Permalink
ADA CASA: window.open() noopener broke the popup object
Browse files Browse the repository at this point in the history
* We're overriding the features in index.js, and noopener is included there
* We're opening a different URL on another domain, so the browser shouldn't
  allow cross-domain access anyways.
  • Loading branch information
benbucksch committed Jul 24, 2024
1 parent 1b6563d commit deb8257
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/logic/Auth/OAuth2Window.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class OAuth2Window extends OAuth2UI {
async login(): Promise<string> {
let url = this.oAuth2.getAuthURL();
// Ends up in e2/src/main/index.ts setWindowOpenHandler(). Features are overridden there.
let popup = window.open(url, "_blank", "center,noopener,noreferrer,oauth2popup") as Window;
let popup = window.open(url, "_blank", "center,oauth2popup") as Window;
assert(popup, "Failed to open OAuth2 window");
return await new Promise((resolve, reject) => {
let ipcRenderer = (window as any).electron.ipcRenderer; // TODO use JPC, or remove window
Expand Down

0 comments on commit deb8257

Please sign in to comment.