fix expression examples in traffic policy modules (ngrok#823)

ip addresses need to be quoted
mustafacco7 · Jul 3, 2024 · 9bfbea1 · 9bfbea1
1 parent 7b6d0db
commit 9bfbea1
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/examples/agent-cli/tcp-traffic-policy.mdx b/examples/agent-cli/tcp-traffic-policy.mdx
@@ -6,8 +6,8 @@ ngrok tcp 22 --policy-file /path/to/policy.yml
 inbound:
   - name: "LimitToKnownIPs"
     expressions:
-      - "conn.client_ip != 8.8.8.8"
-      - "conn.client_ip != 9.9.9.9"
+      - "conn.client_ip != '8.8.8.8'"
+      - "conn.client_ip != '9.9.9.9'"
     actions:
       - type: deny
 ```
diff --git a/examples/agent-cli/tls-traffic-policy.mdx b/examples/agent-cli/tls-traffic-policy.mdx
@@ -6,8 +6,8 @@ ngrok tls 80 --policy-file /path/to/policy.yml
 inbound:
   - name: "LimitToKnownIPs"
     expressions:
-      - "conn.client_ip != 8.8.8.8"
-      - "conn.client_ip != 9.9.9.9"
+      - "conn.client_ip != '8.8.8.8'"
+      - "conn.client_ip != '9.9.9.9'"
     actions:
       - type: deny
 ```
diff --git a/examples/go-sdk/tcp-traffic-policy.mdx b/examples/go-sdk/tcp-traffic-policy.mdx
@@ -16,8 +16,8 @@ func ngrokListener(ctx context.Context) (net.Listener, error) {
             {
               Name: "LimitToKnownIPs",
               Expressions: []string{
-                "conn.client_ip != 8.8.8.8",
-                "conn.client_ip != 9.9.9.9",
+                "conn.client_ip != '8.8.8.8'",
+                "conn.client_ip != '9.9.9.9'",
               },
               Actions: []policy.Action{
                 {

diff --git a/examples/go-sdk/tls-traffic-policy.mdx b/examples/go-sdk/tls-traffic-policy.mdx
@@ -16,8 +16,8 @@ func ngrokListener(ctx context.Context) (net.Listener, error) {
             {
               Name: "LimitToKnownIPs",
               Expressions: []string{
-                "conn.ClientIP != 8.8.8.8",
-                "conn.ClientIP != 9.9.9.9",
+                "conn.ClientIP != '8.8.8.8'",
+                "conn.ClientIP != '9.9.9.9'",
               },
               Actions: []policy.Action{
                 {

diff --git a/examples/k8s/tcp-traffic-policy.mdx b/examples/k8s/tcp-traffic-policy.mdx
@@ -14,8 +14,8 @@ spec:
     inbound:
       - name: "LimitToKnownIPs"
         expressions:
-          - "conn.client_ip != 8.8.8.8"
-          - "conn.client_ip != 9.9.9.9"
+          - "conn.client_ip != '8.8.8.8'"
+          - "conn.client_ip != '9.9.9.9'"
         actions:
           - type: deny
 

diff --git a/examples/k8s/tls-traffic-policy.mdx b/examples/k8s/tls-traffic-policy.mdx
@@ -21,8 +21,8 @@ spec:
     inbound:
       - name: "LimitToKnownIPs"
         expressions:
-          - "conn.ClientIP != 8.8.8.8"
-          - "conn.ClientIP != 9.9.9.9"
+          - "conn.ClientIP != '8.8.8.8'"
+          - "conn.ClientIP != '9.9.9.9'"
         actions:
           - type: deny