Feat #12 - 유치원 선택 API 구현 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 본인이 속한 유치원 목록 중 예약할 유치원을 선택 - 선택한 유치원이 해당 사용자가 속한 유치원인지 검증 - 유효한 유치원 아이디이면 jwt payload에 유치원 아이디 claim을 추가 후 토큰 재발급
|
CI 쪽도 같이 수정해주시면 좋을듯 합니다. Run docker compose run guest_service poetry run black mung_manager/ --check
time="202[4](https://github.com/mung-manager/guest-be/actions/runs/9631053878/job/26562543246?pr=15#step:6:5)-06-23T05:36:56Z" level=warning msg="/home/runner/work/guest-be/guest-be/docker-compose.yml: `version` is obsolete"
Container redis Running
Container postgres_db Running
would reformat /app/mung_manager/pet_kindergardens/apis/urls.py
Oh no! 💥 💔 💥
1 file would be reformatted, [10](https://github.com/mung-manager/guest-be/actions/runs/9631053878/job/26562543246?pr=15#step:6:11)4 files would be left unchanged. |
- exists_by_user_and_pet_kindergarden 메서드명 exists_by_user_and_pet_kindergarden_id으로 수정
- INVALID_PET_KINDERGARDEN_ID에서 NOT_FOUND_PET_KINDERGARDEN로 수정
- 토큰 발급 로직을 auth 모듈로 이동 - 토큰 발급 로직에서 사용자의 유효성 검증 로직을 수행하도록 수정
- black 설정에서 .*urls\.py 패턴 검사 제외하는 항목 제거
JaeHyuckSa
force-pushed
the
feature/issue-012/select-pet-kindergarden
branch
from
c38341c to
b185c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 체크리스트
아래 항목을 확인해 주세요:
PR 유형
이 PR은 어떤 종류의 변경을 가져오나요?
관련 이슈
이슈 번호: #12
어떤 동작은 무엇인가요?
기타 정보