FIX(server): Stale user pointers in whisper cache #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the whisper cache entry was computed while holding the read-lock, it was possible for a user in that cache to get deleted while the voice thread drops the read lock in order to upgrade it to a write lock. In such a case, the cache entry would contain an invalid (stale) user pointer, which can lead to crashes when using the cache later on. By moving the cache entry computation into the block in which we already hold a read lock, we turn computing the cache and adding it to the cache store into an atomic operation. As soon as the cache entry is in the store, deleting a user is no longer an issue as that will implicitly clear all whisper caches (thereby preventing stale cache entries).
davidebeatrici
approved these changes
Apr 2, 2024
This should improve the readability of the whisper code path in the important processMsg function.
Switch to using an unsigned integer as channel ID and rename member variables to no longer include their type as part of the name (and make names more meaningful in general). Additionally, some Qt containers were replaced with std ones.
Krzmbrzl
force-pushed
the
fix-invalid-whisper-target-cache
branch
from
d066fa3 to
b7a46b2
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hartmnt
added a commit
that referenced
this pull request
Apr 9, 2024
…nters in whisper cache " to 1.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the whisper cache entry was computed while holding the read-lock,
it was possible for a user in that cache to get deleted while the voice
thread drops the read lock in order to upgrade it to a write lock. In
such a case, the cache entry would contain an invalid (stale) user
pointer, which can lead to crashes when using the cache later on.
By moving the cache entry computation into the block in which we already
hold a read lock, we turn computing the cache and adding it to the cache
store into an atomic operation. As soon as the cache entry is in the
store, deleting a user is no longer an issue as that will implicitly
clear all whisper caches (thereby preventing stale cache entries).
Additionally, the cache creation has been factored out into its own function (for improved readability)
Checks