FIX(client): Correctly subscribe to both sink and source events in PulseAudioSystem #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lseAudioSystem The second call to pa_context_subscribe() was overriding the first, as a result we were only receiving sink events. This caused hotplugging to fail with devices that don't have any output ports (e.g. USB microphones).
davidebeatrici
force-pushed
the
pulseaudio-source-event-fix
branch
from
4caf617 to
f29e7d3
Compare
Krzmbrzl
approved these changes
Mar 31, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hartmnt
added a commit
that referenced
this pull request
Apr 1, 2024
Backport "Merge PR #6371: FIX(client): Correctly subscribe to both sink and source events in PulseAudioSystem" to 1.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second call to
pa_context_subscribe()was overriding the first, as a result we were only receiving sink events.This caused hotplugging to fail with devices that don't have any output ports (e.g. USB microphones).