DOCS(ice): Add Channel.temporary read-only notice #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kissaki
commented
Mar 15, 2024
Krzmbrzl
approved these changes
Apr 6, 2024
Kissaki
force-pushed
the
ice-channel-readonly
branch
from
c908264 to
0251d8b
Compare
|
I rebased the commit. I am used to GitLab at least indicating the rebase, but I guess GitHub does not do that - presenting it as if I changed my commit. No changes were made to the changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mumble Client UI offers the temporary checkbox only in the Add Channel dialog, not in the Edit Channel dialog.
For Ice consumers it is not obvious that the temporary flag is read-only, and setting it may work but has no effect.
In mumble-voip/mumo#26 it was reported as having no effect.
I did not verify but it is consistent to the Mumble Client UI, hence I am suggesting extending the slice documentation to make this limitation more obvious.