Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT(client): Introduced new mumble API to link and unlink #6336

Closed
wants to merge 79 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
54304f9
FEAT(client): Introduced new mumble API to link and unlink
mryamac Feb 12, 2024
fca6018
REFAC(client): Streamline function naming
Krzmbrzl Feb 13, 2024
8e4618b
FIX(server): Allow unregistered users to transmit access tokens
Hartmnt Feb 13, 2024
03b7da8
TRANSLATION: Update Turkish translation
weblate Feb 10, 2024
40b39ad
TRANSLATION: Update German translation
weblate Feb 10, 2024
8f57587
TRANSLATION: Update Esperanto translation
weblate Feb 10, 2024
bf1ea1d
TRANSLATION: Update Russian translation
weblate Feb 10, 2024
98af414
TRANSLATION: Update Polish translation
weblate Feb 10, 2024
ea2c6d9
TRANSLATION: Update Italian translation
weblate Feb 10, 2024
7e68925
TRANSLATION: Update Spanish translation
weblate Feb 10, 2024
7c1d182
TRANSLATION: Update French translation
weblate Feb 10, 2024
1152e13
TRANSLATION: Update Swedish translation
weblate Feb 10, 2024
90db8ab
TRANSLATION: Update Finnish translation
weblate Feb 10, 2024
da17ec3
TRANSLATION: Update Chinese (Simplified) translation
weblate Feb 10, 2024
b8309ac
TRANSLATION: Update translation files
Krzmbrzl Feb 18, 2024
b325705
FIX(client, ui): Fix log scroll position after loading resources
dexgs Feb 17, 2024
a56ce5c
FIX(ui): Preserve other check-box states if All messages was checked
jlallas384 Feb 27, 2024
367cb2d
FIX(client): Use IPv4 HostAddress representation where applicable
Hartmnt Feb 28, 2024
6f6a9a0
FIX(client): Correctly subscribe to both sink and source events in Pu…
davidebeatrici Mar 31, 2024
e3574cc
FIX(client): Fix incorrect WASAPI sound device handling
Hartmnt Mar 23, 2024
645c354
FIX(a11y): Rework autocomplete username. Use TAB to navigate out of c…
Hartmnt Nov 29, 2022
7a59cbe
FIX(a11y): Introduce accessibility source files
Hartmnt Nov 29, 2022
2610301
FIX(a11y): Add the quality radio button description to the actual rad…
Hartmnt Nov 29, 2022
c24652f
FIX(a11y): Explicitly set the accessible name of "Next" and "Back" bu…
Hartmnt Nov 29, 2022
f18ab50
FIX(a11y): Automatically focus the stop button in the VoiceRecorderDi…
Hartmnt Nov 29, 2022
324f9b4
FIX(a11y): Make users and channels in tree accessible
Hartmnt Nov 30, 2022
c1812fc
FIX(a11y): Add "filtered" to accessibleName for TreeView, if applicable
Hartmnt Nov 30, 2022
9572e1f
FIX(a11y): Change focus handling and accessibility in connect dialog
Hartmnt Nov 30, 2022
c87f1f3
FIX(a11y): Automatically send a focus event to the AudioWizard and Ce…
Hartmnt Dec 12, 2022
8110f06
FIX(a11y): Improve Accessibility for CertWizard
Hartmnt Jan 17, 2024
1b60586
FIX(a11y): Make the info in server and user information dialogs acces…
Hartmnt Jan 6, 2023
b266019
FIX(a11y): Add search dialog action to server context menu
Hartmnt Apr 20, 2023
700c9c8
FIX(a11y): Improve accessibility of the edit shortcut dialog
Hartmnt Apr 20, 2023
4408a01
FIX(a11y): Improve accessibility of configuration dialog buttons
Hartmnt Jun 29, 2023
95d8fd4
FIX(a11y): Fix tab order in settings sub pages
Hartmnt Jan 2, 2024
5c97599
FIX(a11y): Add semantic description to sliders
Hartmnt Jan 17, 2024
83b2af9
FIX(a11y): Fix all buddy labels
Hartmnt Jan 3, 2024
115bfb2
FIX(a11y): Move all accessible name definitions into XML where applic…
Hartmnt Jan 2, 2024
3df032d
FIX(a11y): Update all accessible names and descriptions
Hartmnt Jan 17, 2024
fbb06c5
FIX(a11y): Improve inline volume slider accessibility
Hartmnt Dec 11, 2022
aa41b8c
FIX(a11y): Make plugin config accessible
Hartmnt Jan 7, 2024
57eb116
FIX(a11y): Make message type settings accessible
Hartmnt Jan 7, 2024
f3279a7
FIX(a11y): Make search result tree accessible
Hartmnt Jan 7, 2024
1061f52
FIX(a11y): Make global shortcut settings more accessible
Hartmnt Jan 7, 2024
7ba076f
FIX(ui): Update menu items to comform to design standards
Hartmnt Jan 19, 2024
c4bc0c5
FEAT(client): Add "Move To Own Channel" action to user context menu
Hartmnt Feb 15, 2024
6e14e04
DOCS: Add accessibility checklist
Hartmnt Jan 21, 2024
49f1f36
TRANSLATION: Update translation files
Hartmnt Apr 4, 2024
5200439
TRANSLATION: Update German translation
weblate Mar 31, 2024
c77fdac
TRANSLATION: Update Romanian translation
weblate Mar 31, 2024
e82d6f6
TRANSLATION: Update Catalan translation
weblate Mar 31, 2024
d07650f
TRANSLATION: Update Dutch translation
weblate Mar 31, 2024
462d47f
FIX(server): Stale user pointers in whisper cache
Krzmbrzl Apr 1, 2024
6e9bd40
REFAC(server): Compute whisper target caches in dedicated function
Krzmbrzl Apr 6, 2024
060c905
REFAC(server): Refactor WhisperTarget struct
Krzmbrzl Apr 6, 2024
2583caa
CI(github-actions): Upgrade to Node 20 actions
Krzmbrzl Apr 6, 2024
db375c7
DOCS(ice): Add Channel.temporary read-only notice
Kissaki Mar 15, 2024
b1ebd48
MAINT(github): Drop obsolete, archived forums web-link from issue tem…
Kissaki Apr 7, 2024
19f9e56
DOCS: Fix headlines, Add general intro
Kissaki Apr 7, 2024
854dcac
FEAT(client): disable pipewire input stream while muted
main-- Mar 21, 2024
bc90461
FEAT(client): Add ReNameNoise as a replacement for RNNoise
Hartmnt Mar 19, 2024
05008a7
DOCS(docker): Drop outdated docker compose documentation
Kissaki Apr 10, 2024
5be1f1a
TRANSLATION: Update Turkish translation
weblate Apr 14, 2024
a456710
TRANSLATION: Update German translation
weblate Apr 14, 2024
8a1ad0a
TRANSLATION: Update Polish translation
weblate Apr 14, 2024
b2d1d60
TRANSLATION: Update French translation
weblate Apr 14, 2024
508c146
TRANSLATION: Update Chinese (Simplified) translation
weblate Apr 14, 2024
b636bbe
MAINT: The OCB design is in the public domain
andreasstieger Apr 23, 2024
13c01d0
FEAT(server): Add error code when UDP socket binding fails
Snowknight26 May 7, 2024
c3cc4c1
MAINT: Drop user and group info from tarball
Hartmnt Apr 16, 2024
69d624d
MAINT: Fix generate changelog script
Hartmnt Apr 16, 2024
547b713
FIX(ui): Replace Emoji One icons with MIT licensed flag-icons
andreasstieger May 8, 2024
7558152
TRANSLATION: Update Finnish translation
weblate May 15, 2024
bcdfa0b
TRANSLATION: Update German translation
weblate May 15, 2024
29a2f28
TRANSLATION: Update Russian translation
weblate May 15, 2024
5885410
TRANSLATION: Update Finnish translation
weblate May 15, 2024
665dbde
TRANSLATION: Update Finnish translation
weblate May 15, 2024
23e23fc
TRANSLATION: Update Spanish translation
weblate May 15, 2024
3f12511
TRANSLATION: Update Finnish translation
weblate May 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 0 additions & 3 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: Forums
url: https://forums.mumble.info/
about: The Mumble forums. Here you can discuss stuff or get help and support.
- name: Public Matrix channel
url: https://matrix.to/#/#mumble:matrix.org
about: The public Mumble chatroom.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
outputs:
build_number: ${{ steps.fetch.outputs.build_number }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 1
- id: fetch
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
shell: bash


- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: 'recursive'
fetch-depth: 1
Expand All @@ -69,7 +69,7 @@ jobs:
shell: bash


- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: '${{ env.MUMBLE_BUILD_ENV_PATH }}'
key: ${{ env.MUMBLE_ENVIRONMENT_VERSION }}
Expand Down
9 changes: 6 additions & 3 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
[submodule "3rdparty/speexdsp"]
path = 3rdparty/speexdsp
url = https://github.com/xiph/speexdsp.git
[submodule "3rdparty/rnnoise-src"]
path = 3rdparty/rnnoise-src
url = https://github.com/mumble-voip/rnnoise.git
[submodule "3rdparty/FindPythonInterpreter"]
path = 3rdparty/FindPythonInterpreter
url = https://github.com/Krzmbrzl/FindPythonInterpreter.git
Expand All @@ -28,3 +25,9 @@
[submodule "3rdparty/cmake-compiler-flags"]
path = 3rdparty/cmake-compiler-flags
url = https://github.com/Krzmbrzl/cmake-compiler-flags.git
[submodule "3rdparty/renamenoise"]
path = 3rdparty/renamenoise
url = https://github.com/mumble-voip/ReNameNoise.git
[submodule "3rdparty/flag-icons"]
path = 3rdparty/flag-icons
url = https://github.com/lipis/flag-icons.git
1 change: 1 addition & 0 deletions 3rdparty/flag-icons
Submodule flag-icons added at 38dbe5
1 change: 1 addition & 0 deletions 3rdparty/renamenoise
Submodule renamenoise added at 2a551a
57 changes: 0 additions & 57 deletions 3rdparty/rnnoise-build/CMakeLists.txt

This file was deleted.

122 changes: 0 additions & 122 deletions 3rdparty/rnnoise-build/config.h

This file was deleted.

1 change: 0 additions & 1 deletion 3rdparty/rnnoise-src
Submodule rnnoise-src deleted from a9afcc
27 changes: 17 additions & 10 deletions COMMIT_GUIDELINES.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
# General philosophy
# Mumble Commit Message Guidelines

A commit groups file changes with a title and description of the changes and additional metadata like change date, author, and committer.

These Commit Message Guidelines define and describe how changes shall be structured and described in commits.
Most notably, the text form in which to title the changes.

## General philosophy

- **Each change goes into its own commit**. If you want to summarize what you did with this commit (in the commit message)
and you start using the word "and", you probably want to split the commit up into 2 or more individual commits.
Expand All @@ -10,7 +17,7 @@ each commit).
Also if you put effort into the commit-message, you'll save work when creating a PullRequest as the description is already available.


# Commit message
## Commit message

Commit messages must follow this scheme:

Expand All @@ -26,15 +33,15 @@ The blank lines in between are mandatory. A commit **must** include a `TYPE` and
additionally contain any of the other components listed here.


## Subject line
### Subject line

The first line ("Subject line") should not exceed 50-70 characters. This is what gets displayed on GitHub at first glance, so it
should contain the most important information. In order for it to be as short and precise as possible, there is the `TYPE` and
optionally a `Scope`. With these it should already be clear what this commit is about in general. The short `Summary` should
then include further information that is important to understand the general idea of this commit at a glance.


### TYPE
#### TYPE

The `TYPE` is one of the following:

Expand All @@ -60,13 +67,13 @@ If you feel like you need to use 2 or more types for a single commit but *can't
combine types with `/`: `FEAT/CI: <Summary>`


### Scope
#### Scope

What area is the change about. For now we don't have fixed scope keywords. A scope could be something like `ui`, `client`,
`server`, `ice`, ...


### Summary
#### Summary

The `Summary` is the heart of the subject line. It should contain a **very brief** summary of what you did in that commit.
In order to make this as short as possible, you may use grammatically incorrect sentences
Expand All @@ -79,7 +86,7 @@ If your `Summary` contains "and", you should probably split your commit up.
Note: Issue references (such as #2305) **must not** be used in the `Summary`!


## Message Body
### Message Body

Here you give more details about the commit. Why is it necessary and what are the details of the change. You can use
multiple paragraphs for this and be as verbose as you want.
Expand All @@ -91,7 +98,7 @@ The `Message Body` should contain enough information for someone to be able to l
future and know exactly what it does and why it was needed.


## Footer
### Footer

The `Footer` contains a list of issue references prefixed by a keyword like `Closes`, `Fixes` or `Implements`.

Expand All @@ -111,7 +118,7 @@ Co-Authored-By: Other author <[email protected]>
```


## References
### References

We have used the term "reference" a few times in these guidelines. A *reference* has the form `#<ID>` where `<ID>` is the
ID GitHub assigns to the respective issue or PullRequest (it's the number that is displayed next to the title). You'll
Expand All @@ -120,7 +127,7 @@ automatically by GitHub. You don't have to use a link in your commit message. In
this purpose as this is just unnecessarily verbose and makes it hard to read the commit message outside of GitHub.


## Examples
### Examples

```
FEAT(client): Add possibility to change username
Expand Down
34 changes: 0 additions & 34 deletions docs/DockerCompose.md

This file was deleted.

Loading
Loading