CI(freebsd): Build with C++17 #6315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
force-pushed
the
ci-freebsd-cpp17
branch
from
0e8d687 to
e47de70
Compare
If CMAKE_CXX_STANDARD is specified on the command line when invoking cmake, its value will be respected instead of being overwritten by the project.
The protobuf version on the FreeBSD CI image that we are using requires C++17.
Krzmbrzl
force-pushed
the
ci-freebsd-cpp17
branch
from
e47de70 to
473e69c
Compare
|
@radioactiveman the changes introduced here probably also make the Arch C++17 patch obsolete in that you now can simply specify the standard during cmake invocation instead of patching source files. |
|
Yes, this works now. Thank you. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protobuf version on the FreeBSD CI image that we are using requires
C++17.
Checks