Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the echo combo box to "off" before disabling it #4215

Merged
merged 1 commit into from
May 28, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/mumble/AudioConfigDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ void AudioInputDialog::updateEchoEnableState() {
"the echo canceller, while multichannel echo cancellation passes all audio channels to the echo canceller directly.\n"
"Multichannel echo cancellation requires more CPU, so you should try mixed first"));
} else {
loadComboBox(qcbEcho, 0);
qcbEcho->setEnabled(false);
qcbEcho->setToolTip(QObject::tr("Echo cancellation is not supported for the interface "
"combination \"%1\" (in) and \"%2\" (out).").arg(air->name).arg(outputInterface));
Expand Down