More accessibility enhancements for accessibility clients #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krzmbrzl
added
accessibility
Krzmbrzl
requested changes
May 28, 2020
|
Please do that, I'm not good with that process yet. :-)
…On 5/28/20, Robert Adam ***@***.***> wrote:
@Krzmbrzl requested changes on this pull request.
Could you squash all your commits into a single one and after that run
`./scripts/updatetranslations.sh` in order to make the accessibility strings
available for translation.
If either is difficult for you, just say so. I can also quickly do that for
you :)
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#4211 (review)
--
Signed,
Ethin D. Probst
|
Qt5 provides different ways of improving the accessibility of the application. One of these are accessibility names. This basically assigns a given UI element a name that can be used by e.g. a screen reader. This commit adds lots of these names to almost all dialogs.
Updating 'mumble_en.ts'...
Found 1867 source text(s) (92 new and 1775 already existing)
|
Done. I have force-pushed your branch in order to do that so you'll have to force-pull in order to have these changes reflected locally on your machine :) |
Krzmbrzl
approved these changes
May 28, 2020
|
Thank you for your contribution! :) |
|
Of course! I might make more in the future -- we shall see.
…On 5/31/20, Robert Adam ***@***.***> wrote:
Thank you for your contribution! :)
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#4211 (comment)
--
Signed,
Ethin D. Probst
|
deluxghost
reviewed
Jun 1, 2020
|
@deluxghost thank you for spotting the typos. I have corrected them in #4226 |
|
Sorry about those, I sometimes make those minor typos and don't notice
them. Whoops. :)
…On 6/1/20, Robert Adam ***@***.***> wrote:
@deluxghost thank you for spotting the typos. I have corrected them in
#4226
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#4211 (comment)
--
Signed,
Ethin D. Probst
|
|
No worries. I make typos all the time ^^ |
Krzmbrzl
added a commit
that referenced
this pull request
Jun 2, 2020
These typos have been introduced in #4211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QT5 framework has attributes for accessibility clients (screen readers or other programs used to analyze the accessibility of an application). These attributes are:
These three attributes are not uncommon and are available in most GUI frameworks. This PR sets the accessible name attribute for controls that do not automatically get this attribute set. (This only applies to Windows.) This PR sets these in code, not in QT UI files. These changes could be merged into the UI files themselves with a bit of time and effort, however the QT designer is not accessible to screen reader software. The accessible description remains unset because the other attributes (e.g.: the "What's this?" property) seem to take its place.
The controls that automatically become accessible on win32 are buttons, check boxes, ad tab controls, I believe. On Linux, only tab controls and buttons are accessible, so checkboxes will also need the accessible name attribute set. I may do this in a future PR.
It may be good practice to adopt this across all controls -- set the accessible name property to the text of the label for that control. This will make Mumble accessible across all operating systems that respect this attribute, and if I'm not mistaken that's pretty much all of them.