add support for ingress hook #71
Merged
+168
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
This looks good overall! Thanks for contributing this feature.
Two blockers for merging remain:
- Fixing the clippy complaints that are unrelated to this PR. I do that in Convert a bunch of lifetimes to '_ due to clippy now recommending this #72
- Bump the MSRV to 1.63, since the newer rustc seems to need that: https://github.com/mullvad/nftnl-rs/actions/runs/12828434721/job/35778282125?pr=71. Please remember to bump it in
.github/workflows/build-and-test.ymlas well as in bothCargo.tomlfiles whererust-versionis set.
Anh-Kagi
force-pushed
the
main
branch
2 times, most recently
from
e5d7f61 to
e9227b5
Compare
|
Ok! I updated the msrv |
|
Awesome! I just merged my PR fixing the clippy complaints about |
- added Ingress in enum Hook - added set_device() method in struct Chain - updated libc dependency in nftnl-sys - added an example file for ingress hook - update MSRV to 1.63.0
|
And here it is ! |
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds support for the ingress hook added in netfilter 0.9.7. This needed to update the libc dependency in nftnl-sys to 0.2.166 at least.
As ingress hooks need to be bound to a device, i also added a
set_devicemethod in Chain.And I've added an example file for this hook, since it works a little differently from the others.
This change is