Update screenshot tests to use correct iPad models #7503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
update-screenshot-tests-to-use-correct-ipad-models
branch
from
7ecebbd to
fd204f7
Compare
rablador
force-pushed
the
update-screenshot-tests-to-use-correct-ipad-models
branch
from
fd204f7 to
1535eb1
Compare
mojganii
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
rablador
commented
Jan 23, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
mojganii
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
rablador
deleted the
update-screenshot-tests-to-use-correct-ipad-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot tests fail due to using the wrong iPad models. We should use
iPad Pro (11-inch) (M4)andiPad Pro (13-inch) (M4).This change is