IOS-995 Show exit constraints in connect view

[acb-mv]

This updates the Connect button to show the name of the selected destination. If the user has selected a custom list, this will be the list name, otherwise depending on the relays chosen, it will be in the format "Country", "City, Country" or "City (hostname)".

---

This change is 

[linear]

IOS-995 Show currently selected exit constraints in connect view

[rablador]

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv)

---

ios/MullvadVPNTests/MullvadVPN/View controllers/Tunnel/DestinationDescriberTests.swift line 89 at r1 (raw file):

    }

    func testDescribeCountryDest() {

Nit: Full function names.

---

ios/MullvadREST/Relay/RelayWithLocation.swift line 61 at r1 (raw file):

        locations: [String: REST.ServerLocation]
    ) -> [RelayWithLocation<T>] {
        /// thiis used to be `RelaySelector.mapRelays`

I think it's ok to omit this comment.

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/DestinationDescriber.swift line 15 at r1 (raw file):

protocol DestinationDescribing {
    func describe(_ loc: UserSelectedRelays) -> String?

Nit: I'd prefer using the full location name here and below.

[buggmagnet]

Reviewed 9 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @acb-mv and @rablador)

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/DestinationDescriber.swift line 15 at r1 (raw file):
Not even a nit, the swift guidelines are pretty explicit about this

Avoid abbreviations. Abbreviations, especially non-standard ones, are effectively terms-of-art, because understanding depends on correctly translating them into their non-abbreviated forms.

---

ios/MullvadVPNTests/MullvadVPN/View controllers/Tunnel/DestinationDescriberTests.swift line 20 at r1 (raw file):

            cachedRelays: CachedRelays(
                relays: .init(
                    locations: [

No need to create another list of fake relays, we can use ServerRelaysResponseStubs.sampleRelays here instead

---

ios/MullvadVPNTests/MullvadVPN/View controllers/Tunnel/DestinationDescriberTests.swift line 85 at r1 (raw file):

        XCTAssertEqual(
            describer.describe(.init(locations: [], customListSelection: .init(listId: listid, isList: true))),
            "NameOfList"

Please check the desktop behaviour with custom lists, name list is only displayed when the list itself is selected, if you select a sub location in a list, it will be the location name being displayed instead.

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/DestinationDescriber.swift line 42 at r1 (raw file):

        switch locationSpec {
        case .country: serverLocation.country
        case .city: "\(serverLocation.city), \(serverLocation.country)"

We should double check with the desktop team, currently they only show the city name without the country next to it.
See attached screenshot

[buggmagnet]

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @acb-mv and @rablador)

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/DestinationDescriber.swift line 42 at r1 (raw file):

Previously, buggmagnet wrote…

We should double check with the desktop team, currently they only show the city name without the country next to it.
See attached screenshot

@waahlnaden test ping ?

[acb-mv]

Reviewable status: 11 of 14 files reviewed, 5 unresolved discussions (waiting on @buggmagnet, @rablador, and @waahlnaden)

---

ios/MullvadREST/Relay/RelayWithLocation.swift line 61 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

I think it's ok to omit this comment.

Done.

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/DestinationDescriber.swift line 15 at r1 (raw file):

Previously, buggmagnet wrote…

Not even a nit, the swift guidelines are pretty explicit about this

Avoid abbreviations. Abbreviations, especially non-standard ones, are effectively terms-of-art, because understanding depends on correctly translating them into their non-abbreviated forms.

It's not actually part of the function signature, but fair enough

---

ios/MullvadVPN/View controllers/Tunnel/ConnectionView/DestinationDescriber.swift line 42 at r1 (raw file):

Previously, buggmagnet wrote…

@waahlnaden test ping ?

Fixed

---

ios/MullvadVPNTests/MullvadVPN/View controllers/Tunnel/DestinationDescriberTests.swift line 20 at r1 (raw file):

Previously, buggmagnet wrote…

No need to create another list of fake relays, we can use ServerRelaysResponseStubs.sampleRelays here instead

Done

---

ios/MullvadVPNTests/MullvadVPN/View controllers/Tunnel/DestinationDescriberTests.swift line 85 at r1 (raw file):

Previously, buggmagnet wrote…

Please check the desktop behaviour with custom lists, name list is only displayed when the list itself is selected, if you select a sub location in a list, it will be the location name being displayed instead.

OK, this has been fixed

[rablador]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @waahlnaden)

[rablador]

Reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @waahlnaden)

[rablador]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @waahlnaden)

[rablador]

Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @waahlnaden)

[buggmagnet]

Reviewed 2 of 14 files at r1, 1 of 3 files at r2, 1 of 6 files at r3, 1 of 1 files at r4, 6 of 6 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved