Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Direct only pop up design #7442

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Jan 9, 2025

This PR updates the copyright text and replaces the info icon with a warning icon in the popup displayed when a user enables 'Direct Only' while the selected location does not support Daita.

Before After
Image 1 Image 2

This change is Reviewable

Simulator Screenshot - iPhone 15 - 2025-01-13 at 10 50 48

@mojganii mojganii added the iOS Issues related to iOS label Jan 9, 2025
@mojganii mojganii self-assigned this Jan 9, 2025
Copy link

linear bot commented Jan 9, 2025

rablador
rablador previously approved these changes Jan 10, 2025
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

pinkisemils
pinkisemils previously approved these changes Jan 13, 2025
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mojganii mojganii force-pushed the update-direct-only-pop-up-design-ios-1001 branch from bf38832 to fb7acc5 Compare January 13, 2025 08:59
@mojganii mojganii dismissed stale reviews from rablador and pinkisemils via 00d6caf January 13, 2025 09:34
@mojganii mojganii force-pushed the update-direct-only-pop-up-design-ios-1001 branch from fb7acc5 to 00d6caf Compare January 13, 2025 09:34
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't that say "Enable Daita" instead ?
Screenshot 2025-01-13 at 10.38.54.png

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to request changes

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be Enable "Direct only"

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)

@mojganii mojganii force-pushed the update-direct-only-pop-up-design-ios-1001 branch from 00d6caf to 698e29f Compare January 13, 2025 09:45
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the update-direct-only-pop-up-design-ios-1001 branch from 698e29f to 9895aa9 Compare January 13, 2025 10:30
@buggmagnet buggmagnet merged commit 78e9389 into main Jan 13, 2025
11 checks passed
@buggmagnet buggmagnet deleted the update-direct-only-pop-up-design-ios-1001 branch January 13, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants