-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Direct only pop up design #7442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
bf38832
to
fb7acc5
Compare
fb7acc5
to
00d6caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that say "Enable Daita" instead ?
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to request changes
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be Enable "Direct only"
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)
00d6caf
to
698e29f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
698e29f
to
9895aa9
Compare
This PR updates the copyright text and replaces the info icon with a warning icon in the popup displayed when a user enables 'Direct Only' while the selected location does not support Daita.
This change is