-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ip -6 addr
command for setting ipv6 addr on linux.
#7438
Use ip -6 addr
command for setting ipv6 addr on linux.
#7438
Conversation
7a0d5f5
to
64530a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)
talpid-tunnel/src/tun_provider/unix.rs
line 171 at r1 (raw file):
let device = self.dev.tun_name().unwrap(); // TODO: Do not unwrap! Command::new("ip") .args(["-6", "addr", "add", &dbg!(ipv6), "dev", &device])
dbg!
😄
Code quote:
&dbg!(ipv6)
64530a2
to
1dc220f
Compare
1dc220f
to
020c0a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
talpid-tunnel/src/tun_provider/unix.rs
line 171 at r1 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
dbg!
😄
Just keeping you on your toes 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
020c0a7
to
6df989c
Compare
Using tun throws strange I/O errors. There may be a bug related to ipv6 in tun 0.7.10
6df989c
to
b368059
Compare
This change is