Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ip -6 addr command for setting ipv6 addr on linux. #7438

Merged

Conversation

hulthe
Copy link
Contributor

@hulthe hulthe commented Jan 9, 2025

This change is Reviewable

Copy link

linear bot commented Jan 9, 2025

@hulthe hulthe force-pushed the error-starting-wireguard-go-tunnel-with-ipv6-on-linux-des-1628 branch 3 times, most recently from 7a0d5f5 to 64530a2 Compare January 9, 2025 13:51
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hulthe)


talpid-tunnel/src/tun_provider/unix.rs line 171 at r1 (raw file):

                let device = self.dev.tun_name().unwrap(); // TODO: Do not unwrap!
                Command::new("ip")
                    .args(["-6", "addr", "add", &dbg!(ipv6), "dev", &device])

dbg! 😄

Code quote:

&dbg!(ipv6)

@hulthe hulthe force-pushed the error-starting-wireguard-go-tunnel-with-ipv6-on-linux-des-1628 branch from 64530a2 to 1dc220f Compare January 9, 2025 14:23
@hulthe hulthe marked this pull request as ready for review January 9, 2025 14:25
@hulthe hulthe force-pushed the error-starting-wireguard-go-tunnel-with-ipv6-on-linux-des-1628 branch from 1dc220f to 020c0a7 Compare January 9, 2025 14:26
Copy link
Contributor Author

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


talpid-tunnel/src/tun_provider/unix.rs line 171 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

dbg! 😄

Just keeping you on your toes 😇

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@hulthe hulthe force-pushed the error-starting-wireguard-go-tunnel-with-ipv6-on-linux-des-1628 branch from 020c0a7 to 6df989c Compare January 9, 2025 14:31
Using tun throws strange I/O errors. There may be a bug related to ipv6
in tun 0.7.10
@hulthe hulthe force-pushed the error-starting-wireguard-go-tunnel-with-ipv6-on-linux-des-1628 branch from 6df989c to b368059 Compare January 9, 2025 14:47
@hulthe hulthe merged commit dfc069c into main Jan 9, 2025
54 checks passed
@hulthe hulthe deleted the error-starting-wireguard-go-tunnel-with-ipv6-on-linux-des-1628 branch January 9, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants