Fix build issues on xcode 16 ios 740 #6639
Conversation
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved line 17 at r1 (raw file):
"location" : "https://github.com/mullvad/wireguard-apple.git", "state" : { "revision" : "a31e50faa79c85e4da054bcc8e1fb05db3b834e6"
Intentional?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadVPN.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved line 17 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
Intentional?
I should have mentioned that in the notes, my bad.
This is the merge commit from our fork of wireguard-apple without which, WireGuardKit won't compile.
So yes, definitely intentional
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
buggmagnet
force-pushed
the
fix-build-issues-on-xcode-16-ios-740
branch
from
831dc66 to
48691d3
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
|
🚨 End to end tests failed. Please check the failed workflow run. |
This PR enables us to build both with the currently used Xcode Versions (15.2, 15.0.1) and also with Xcode 16-beta
This change is