Prevent duplicate list names in custom lists

[rablador]

It shouldn't be possible to save a custom list with an already existing list name.

---

This change is 

[linear]

IOS-599 Custom list crashes when naming a list with the name of an existing list during edit

[mojganii]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadSettings/CustomListRepository.swift line 43 at r1 (raw file):

        let persistedListWithSameName = lists.first {
            $0.name.localizedCaseInsensitiveCompare(list.name) == .orderedSame

do we really to compare the localized value of a name? I'm of the opinion it's just a name regardless of its language.

---

ios/MullvadSettings/CustomListRepository.swift line 46 at r1 (raw file):

        }

        if let persistedListWithSameName, persistedListWithSameName.id != list.id {

nit : duplicatedName

[mojganii]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rablador)

---

ios/MullvadSettings/CustomListRepository.swift line 46 at r1 (raw file):

Previously, mojganii wrote…

nit : duplicatedName

the name of class defines the object takes the responsibility of storing, having persisted is redundant.

[rablador]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadSettings/CustomListRepository.swift line 43 at r1 (raw file):

Previously, mojganii wrote…

do we really to compare the localized value of a name? I'm of the opinion it's just a name regardless of its language.

Maybe you're right, I'll make a change.

---

ios/MullvadSettings/CustomListRepository.swift line 46 at r1 (raw file):

Previously, mojganii wrote…

the name of class defines the object takes the responsibility of storing, having persisted is redundant.

It's the same variable, just that it's unwrapped here, just like guard let self else ....

I think it's good to distinguish where the two lists comes from. One is passed in to the function as param, the other is loaded from store. listWithSameName feels a little too ambiguous for me.

[rablador]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadSettings/CustomListRepository.swift line 46 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

It's the same variable, just that it's unwrapped here, just like guard let self else ....

I think it's good to distinguish where the two lists comes from. One is passed in to the function as param, the other is loaded from store. listWithSameName feels a little too ambiguous for me.

Did some refactoring to make it a little less obtuse.

[acb-mv]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[mojganii]

Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.