Refactor API access mode rotation

[dlon]

Fix DES-635.

---

This change is 

[linear]

DES-635 Refactor API access mode rotation

[MarkusPettersson98]

Very nice! Left som very minor comments 😊

Reviewed 3 of 10 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dlon)

---

mullvad-api/src/lib.rs line 181 at r2 (raw file):

            force_direct: force_direct
                .map(|force_direct_env| force_direct_env.to_lowercase() != "0")
                .unwrap_or(false),

Is this supposed to be changed in this PR? 😊

Code quote:

            force_direct: force_direct
                .map(|force_direct_env| force_direct_env.to_lowercase() != "0")
                .unwrap_or(false),

---

mullvad-daemon/src/api.rs line 275 at r2 (raw file):

                        let mut new_setting = setting.clone();
                        new_setting.enable();
                        new_setting

Compile error - simply remove the return value

Code quote:

                        new_setting

---

mullvad-daemon/src/api.rs line 489 at r2 (raw file):

            }
            None => {
                // Current method was removed: A new access mehtod will suddenly have the same index as the one

Typo in old comment 😄

Code quote:

mehtod

[dlon]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: 9 of 11 files reviewed, 2 unresolved discussions (waiting on @dlon and @MarkusPettersson98)

---

mullvad-api/src/lib.rs line 181 at r2 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Is this supposed to be changed in this PR? 😊

Nope! Fixed

---

mullvad-daemon/src/api.rs line 275 at r2 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Compile error - simply remove the return value

Done.

[MarkusPettersson98]

Reviewed all commit messages.
Reviewable status: 9 of 11 files reviewed, all discussions resolved (waiting on @dlon)