Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport TunnelSettingsV4 from quantum resistance exploratory branch #5795

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

acb-mv
Copy link
Contributor

@acb-mv acb-mv commented Feb 9, 2024

This PR cherry-picks the TunnelSettings version bump (TunnelSettingsV4) from the quantum resistance branch, adding a quantum resistance setting with three states (automatic, offand on) and making V4 the new version of settings. The purpose of this backport is to unblock any other possible changes to settings and avert merging issues.


This change is Reviewable

@acb-mv acb-mv added the iOS Issues related to iOS label Feb 9, 2024
@acb-mv acb-mv requested a review from buggmagnet February 9, 2024 10:21
@acb-mv acb-mv self-assigned this Feb 9, 2024
Copy link

linear bot commented Feb 9, 2024

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the backport-tunnelsettingsv4-to-main-ios-501 branch from 8eeb29d to 0c04ca0 Compare February 9, 2024 14:51
@PaulCharlton
Copy link

Hey @acb-mv ... are you already working on the entire IOS quantum implementation? I was just looking over what needs to be done, and ready/willing/able to work on that. However, I do wish to avoid duplication of effort.

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PaulCharlton, that's very kind of you to propose help on this!

The iOS side of quantum resistance will be very limited (mostly UI facade changes, and saving this to the settings on the device)
Most of the functionality will be built in a Rust crate, reusing parts of the desktop implementation, and exposed via an FFI interface that the PacketTunnel will call.

What kind of solution did you have in mind ?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the backport-tunnelsettingsv4-to-main-ios-501 branch from 0c04ca0 to a4f88b9 Compare February 12, 2024 09:28
@buggmagnet buggmagnet merged commit 88fcf98 into main Feb 12, 2024
5 checks passed
@buggmagnet buggmagnet deleted the backport-tunnelsettingsv4-to-main-ios-501 branch February 12, 2024 09:29
@PaulCharlton
Copy link

PaulCharlton commented Feb 13, 2024

Hi @PaulCharlton, that's very kind of you to propose help on this!

The iOS side of quantum resistance will be very limited (mostly UI facade changes, and saving this to the settings on the device) Most of the functionality will be built in a Rust crate, reusing parts of the desktop implementation, and exposed via an FFI interface that the PacketTunnel will call.

What kind of solution did you have in mind ?

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

The yes for the scope UI/save settings locally + the automated testing for those.
As for the Rust Crate — seems right at a high level. Noting, IOS actually provides some callbacks to allow custom override of the TLS handshake in its native TLS stack (if used for obfuscation)

I created issue #5800 for tracking of IOS changes for Quantum Secure, and have a [WIP] merge at #5801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants