-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport TunnelSettingsV4 from quantum resistance exploratory branch #5795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
8eeb29d
to
0c04ca0
Compare
Hey @acb-mv ... are you already working on the entire IOS quantum implementation? I was just looking over what needs to be done, and ready/willing/able to work on that. However, I do wish to avoid duplication of effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PaulCharlton, that's very kind of you to propose help on this!
The iOS side of quantum resistance will be very limited (mostly UI facade changes, and saving this to the settings on the device)
Most of the functionality will be built in a Rust crate, reusing parts of the desktop implementation, and exposed via an FFI interface that the PacketTunnel will call.
What kind of solution did you have in mind ?
Reviewable status: complete! all files reviewed, all discussions resolved
0c04ca0
to
a4f88b9
Compare
The yes for the scope UI/save settings locally + the automated testing for those. I created issue #5800 for tracking of IOS changes for Quantum Secure, and have a [WIP] merge at #5801 |
This PR cherry-picks the TunnelSettings version bump (
TunnelSettingsV4
) from the quantum resistance branch, adding a quantum resistance setting with three states (automatic
,off
andon
) and making V4 the new version of settings. The purpose of this backport is to unblock any other possible changes to settings and avert merging issues.This change is