Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old and unused Localizible file #5747

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Feb 1, 2024

We have an old and unused file for localisations that go against our current way or translating strings. We should remove it to uphold consistency.


This change is Reviewable

@rablador rablador added the iOS Issues related to iOS label Feb 1, 2024
Copy link

linear bot commented Feb 1, 2024

@rablador rablador force-pushed the remove-old-and-unused-localizible-file-ios-476 branch from 9803637 to c5f7056 Compare February 1, 2024 09:00
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the remove-old-and-unused-localizible-file-ios-476 branch from c5f7056 to 57a85f8 Compare February 2, 2024 07:56
@buggmagnet buggmagnet merged commit 3345569 into main Feb 2, 2024
5 checks passed
@buggmagnet buggmagnet deleted the remove-old-and-unused-localizible-file-ios-476 branch February 2, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants