Add preliminary settings page for relay IP overrides

[rablador]

Currently, there is no bespoke iOS design for this, but that will not stop us. We should follow the desktop UI mockups for now.

---

This change is 

[linear]

IOS-450 Add preliminary settings page for relay IP overrides

[mojganii]

Reviewable status: 0 of 9 files reviewed, 4 unresolved discussions (waiting on @buggmagnet and @rablador)

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideCoordinator.swift line 13 at r1 (raw file):

import UIKit

class IPOverrideCoordinator: Coordinator, Presenting, SettingsChildCoordinator {

we can eliminate conforming Presenting for now but if you think we need to present modal top of that in the future, let's keep it that

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 15 at r1 (raw file):

        let view = UIStackView()
        view.axis = .vertical
        view.spacing = 20

try to use the values in UIMetrics or make the custom layout for this

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 62 at r1 (raw file):

        infoButton.tintColor = .white
        infoButton.setImage(UIImage(resource: .iconInfo), for: .normal)
        infoButton.heightAnchor.constraint(equalToConstant: 24).isActive = true

use the padding in UIMetrics

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 66 at r1 (raw file):

        let headerView = UIStackView(arrangedSubviews: [label, infoButton, UIView()])
        headerView.spacing = 8

the same goes for here

[rablador]

Reviewable status: 0 of 9 files reviewed, 4 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideCoordinator.swift line 13 at r1 (raw file):

Previously, mojganii wrote…

we can eliminate conforming Presenting for now but if you think we need to present modal top of that in the future, let's keep it that

We will need it in the next steps when we present document picker and text input view controller.

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 15 at r1 (raw file):

Previously, mojganii wrote…

try to use the values in UIMetrics or make the custom layout for this

This is a very specific margin for this view only. Do we need to "pollute" the UIMetrics with non-generic margins? This answer goes for all the similar comments below.

[mojganii]

Good job!

Reviewable status: 0 of 9 files reviewed, 3 unresolved discussions (waiting on @rablador)

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 15 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

This is a very specific margin for this view only. Do we need to "pollute" the UIMetrics with non-generic margins? This answer goes for all the similar comments below.

do we agree to keep specific spacings and layout constants in that view? if we are going to put shared values in UIMetrics then it's true. but I'm not sure if we agreed or not

[rablador]

Reviewable status: 0 of 9 files reviewed, 3 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 15 at r1 (raw file):

Previously, mojganii wrote…

do we agree to keep specific spacings and layout constants in that view? if we are going to put shared values in UIMetrics then it's true. but I'm not sure if we agreed or not

I'm not sure to be honest. I think I'd rather have shared values in UIMetrics, but we haven't really discussed it properly. I'll start a topic in the ios channel so that we can have a chat about it.

[buggmagnet]

Reviewed 4 of 8 files at r1, 2 of 3 files at r2, 3 of 4 files at r4, all commit messages.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions (waiting on @mojganii)