-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a staging configuration that automatically targets the staging environment #5677
Add a staging configuration that automatically targets the staging environment #5677
Conversation
de89dfb
to
f8c6ed3
Compare
Looks like I forgot about GH CI, will fix soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 10 files at r1, 2 of 10 files at r2.
Reviewable status: 4 of 16 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN.xcodeproj/project.pbxproj
line 6443 at r2 (raw file):
GCC_NO_COMMON_BLOCKS = YES; GCC_OPTIMIZATION_LEVEL = 0; GCC_PREPROCESSOR_DEFINITIONS = (
Could we also change the fake release schema to be a build configuration? Then we have less schemas, which I see as only a good thing. And the only thing that's different for the fake release is that the debug flag is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 10 files at r1, 8 of 10 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 10 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN.xcodeproj/project.pbxproj
line 6443 at r2 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Could we also change the fake release schema to be a build configuration? Then we have less schemas, which I see as only a good thing. And the only thing that's different for the fake release is that the debug flag is not set.
Sounds good to me
9cb81e9
to
5edfe8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
5edfe8e
to
fb4cfb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 8 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN.xcodeproj/project.pbxproj
line 6975 at r4 (raw file):
isa = XCBuildConfiguration; buildSettings = { ALWAYS_SEARCH_USER_PATHS = NO;
Can this be inherited from other the base config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN.xcodeproj/project.pbxproj
line 6975 at r4 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Can this be inherited from other the base config?
According to the documentation, we should be able to use $(inherited)
to do that.
Any setting we find in this list should be overridable via xcconfig
files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
021235f
to
7063688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
7063688
to
6e6d503
Compare
6e6d503
to
93bd690
Compare
This PR creates a staging environment. The API endpoint and IP are now hardcoded in the
Api.xcconfig
file.The API endpoint and IP address are now loaded and stored in the
Info.plist
files of both the packet tunnel and the main host application.In order to use the staging environment, In Xcode go to the following menu :
Product > Scheme > Edit Scheme
In the
Run
section, select theStaging
environmentIf you want to test this PR
Api.xcconfig.template
file and replace the values with the API endpoint, and the staging endpoint.Staging
build schemeThis change is