Skip to content

Commit

Permalink
PR feedback fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
niklasberglund committed Dec 17, 2024
1 parent b067b08 commit 4169fef
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/android-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,18 @@ on:
type: boolean
required: false
mockapi_test_repeat:
description: Mockapi test repeat(self hosted)
description: Mockapi test repeat (self hosted)
default: '1'
required: true
type: string
e2e_test_repeat:
description: e2e test repeat(self hosted)
description: e2e test repeat (self hosted)
default: '0'
required: true
type: string
e2e_tests_infra_flavor:
description: >
Infra environment to run e2e tests on(prod/stagemole).
Infra environment to run e2e tests on (prod/stagemole).
If set to 'stagemole' test-related artefacts will be uploaded.
default: 'stagemole'
required: true
Expand Down Expand Up @@ -348,7 +348,9 @@ jobs:

- name: Build stagemole app
uses: burrunan/gradle-cache-action@v1
if: github.event.inputs.e2e_test_repeat != '0'
if: >
(github.event.inputs.e2e_test_repeat != '0' && github.event.inputs.e2e_tests_infra_flavor == 'stagemole') ||
github.event.inputs.run_firebase_tests == 'true'
with:
job-id: jdk17
arguments: assemblePlayStagemoleDebug
Expand Down
4 changes: 4 additions & 0 deletions android/scripts/run-instrumented-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ case "$TEST_TYPE" in
echo ""
echo "Error: The 'e2e' test type with billing flavor 'play' require infra flavor 'stagemole'."
exit 1
elif [[ $BILLING_FLAVOR == "oss" && $INFRA_FLAVOR != "prod" ]]; then
echo ""
echo "Error: The 'e2e' test type with billing flavor 'oss' require infra flavor 'prod'."
exit 1
fi
OPTIONAL_TEST_ARGUMENTS=""
if [[ -n ${INVALID_TEST_ACCOUNT_NUMBER-} ]]; then
Expand Down

0 comments on commit 4169fef

Please sign in to comment.