W-17607446: Handle missing fields in DefaultMessageBuilder and ensure that one field is not serialized in DefaultEventBuilder #14175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrodro83
requested changes
Jan 24, 2025
Comment on lines
+55
to
+58
| private final Map<String, TypedValue<Serializable>> inboundProperties = new CaseInsensitiveMapWrapper<>(); | ||
| private final Map<String, TypedValue<Serializable>> outboundProperties = new CaseInsensitiveMapWrapper<>(); | ||
| private Map<String, DataHandler> inboundAttachments = new LinkedHashMap<>(); | ||
| private Map<String, DataHandler> outboundAttachments = new LinkedHashMap<>(); |
There was a problem hiding this comment.
these should not be added back. If they are missing, that should be handled by the serializer
| @@ -418,7 +418,7 @@ public static class InternalEventImplementation implements InternalEvent { | |||
| private final boolean notificationsEnabled; | |||
|
|
|||
| private final CaseInsensitiveHashMap<String, TypedValue<?>> variables; | |||
| private final CaseInsensitiveHashMap<String, TypedValue<?>> parameters; | |||
| private transient final CaseInsensitiveHashMap<String, TypedValue<?>> parameters; | |||
There was a problem hiding this comment.
this should be handled in the serializer as well
|
--validate |
…ld is not serialized in DefaultEventBuilder
d4nielyan9
force-pushed
the
test/W-16853216
branch
from
3159752 to
24a21b6
Compare
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.