[DataGrid] Avoid undefined value for pagination rowCount
#16558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Cherniavskyi <[email protected]>
cherniavskii
added
test
component: data grid
|
Deploy preview: https://deploy-preview-16558--material-ui-x.netlify.app/ |
|
One test is failing with React 18. Should we merge and address this later, since this fixes a regression? |
LukasTy
reviewed
Feb 13, 2025
There was a problem hiding this comment.
One test is failing with React 18. Should we merge and address this later, since this fixes a regression?
Makes sense to me if it's not trivial to solve that particular test failure. 👍
It's still better than the current state.
However, I'm not in the best position to judge how easy it is to address that particular test failure. 🙈
MBilalShafi
approved these changes
Feb 13, 2025
|
I also didn't check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #16488