[docs] Cleanup the pickers migration guide #15310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
flaviendelangle
commented
Nov 7, 2024
| @@ -141,19 +141,14 @@ these props will now be passed to the hidden `<input />` element. | |||
| If you are passing a custom field component to your pickers, you need to create a new one that is using the accessible DOM structure. | |||
| This new component will need to use the `PickersSectionList` component instead of an `<input />` HTML element. | |||
|
|
|||
| You can have a look at the [Using a custom input](/x/react-date-pickers/custom-field/#using-a-custom-input) to have a concrete example. | |||
|
|
|||
| :::info | |||
There was a problem hiding this comment.
This is not going to happen 😆
|
|
||
| ### Migrate `slots.textField` | ||
|
|
||
| If you are passing a custom `TextField` component to your fields and pickers, | ||
| you need to create a new one that is using the accessible DOM structure. | ||
|
|
||
| You can have a look at the second demo of the [Wrapping PickersTextField](/x/react-date-pickers/custom-field/#wrapping-pickerstextfield) to have a concrete example. | ||
| You can have a look at the [Wrapping PickersTextField](/x/react-date-pickers/custom-field/#wrapping-pickerstextfield) section to have a concrete example. |
There was a problem hiding this comment.
There is just one demo on this section
| @@ -293,7 +288,28 @@ The following variables were renamed to have a coherent `Picker` / `Pickers` pre | |||
| + const pickerContext = usePickerContext(); | |||
| ``` | |||
|
|
|||
| ## Removed types | |||
| ## Typing breaking changes | |||
There was a problem hiding this comment.
I want to wait for the full typing rework before spending time doing a good migration guide, but since it can impact a lot of people, I added a very summarized version both here and on the changelog.
|
Deploy preview: https://deploy-preview-15310--material-ui-x.netlify.app/ Updated pages: |
LukasTy
approved these changes
Nov 7, 2024
| @@ -141,19 +141,14 @@ these props will now be passed to the hidden `<input />` element. | |||
| If you are passing a custom field component to your pickers, you need to create a new one that is using the accessible DOM structure. | |||
| This new component will need to use the `PickersSectionList` component instead of an `<input />` HTML element. | |||
|
|
|||
| You can have a look at the [Using a custom input](/x/react-date-pickers/custom-field/#using-a-custom-input) to have a concrete example. | |||
|
|
|||
| :::info | |||
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
docs/data/migration/migration-pickers-v7/migration-pickers-v7.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.