Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][LinearProgress] Deprecate composed classes #44933

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

headironc
Copy link

part of 41282

@zannager zannager added the component: LinearProgress The React component. label Jan 4, 2025
@zannager zannager requested a review from DiegoAndai January 4, 2025 05:49
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @headironc!

A couple of this:

  1. The MuiLinearProgress-bar1 and MuiLinearProgress-bar2 classes don't exist, we need to add them. When you add them, may I also ask you to add tests to check they're correctly applied? You can use this PR as a guide: https://github.com/mui/material-ui/pull/42281/files
  2. May I also ask you to prepare a sandbox (You can use this one which uses this PR builds) testing that the deprecated classes are correctly replaced by the suggested compositions? For example:

In the sandbox, have two linear progress components, one with:

<LinearProgress
    sx={[`&.${linearProgressClasses.bar1Buffer}`]: {
        backgroundColor: 'red',
    }
/>

and another with:

<Drawer
    sx={[`&.${linearProgressClasses.buffer} > .${linearProgressClasses.bar1}`]: {
        backgroundColor: 'red',
    }
/>

And the result should be the same.

No need to do it with all the combinations, these should be enough:

  • bar1Buffer
  • bar1Determinate
  • bar1Indeterminate
  • bar2Buffer
  • barColorPrimary
  • dashedColorPrimary

@headironc
Copy link
Author

@DiegoAndai Okay, I'll finish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: LinearProgress The React component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants