[Menu] Deprecate *Props and complete slots, slotProps
#44913
Conversation
siriwatknp
added
the
component: menu
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
| * [Follow this guide](https://mui.com/material-ui/transitions/#transitioncomponent-prop) to learn more about the requirements for this component. | ||
| * @default Grow | ||
| */ | ||
| TransitionComponent: PropTypes.elementType, |
There was a problem hiding this comment.
Why are we adding this one? slots.transition should be used instead.
There was a problem hiding this comment.
I think it's because I move TransitionComponent to the the props, let me find other way.
There was a problem hiding this comment.
But did it work beofre this? I'm asking because it's not included in the API: https://mui.com/material-ui/api/menu/.
If it never worked before, there's no need to add it now.
If it worked, we can add it but we should:
- Add it to the types (as it was incorrectly missing before)
- Add the deprecated message
There was a problem hiding this comment.
If it never worked before, there's no need to add it now.
This is because the TransitionComponent pass through …other before. But now, we need this backward compatibility with TransitionComponent={slots.transition ?? other.TransitionComponent}.
The moment I added the line, the generatePropTypes attached TransitionComponent to the proptypes. I haven't find a way to disable it in this case.
I think I will work on Popover first (to deprecate the TransitionComponent and then once it's done will revisit this PR)
There was a problem hiding this comment.
Oh, I see now.
Right, so if we finish the Popover first, then we can use its slots instead of TransitionComponent and we don't need to rescue TransitionComponent from other, this plan makes sense 👍🏼
github-actions
bot
added
the
PR: out-of-date
Part of #41281
MenuListPropsandTransitionProps.slots.transitionandslots.list