Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Fix closing the menu when clicking on checkboxitem/radioitem #1301

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[Menu] Fix closing the menu when clicking on checkboxitem/radioitem #1301

merged 2 commits into from
Jan 8, 2025

Conversation

michaldudak
Copy link
Member

Prevents closing the menu when defaultOpen = true and user clicks on checkboxitem/radioitem.

Fixes #1297

@michaldudak michaldudak added component: menu This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Jan 7, 2025
@mui-bot
Copy link

mui-bot commented Jan 7, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-1301--base-ui.netlify.app/

Generated by 🚫 dangerJS against 12c003e

@michaldudak michaldudak merged commit 2b05351 into mui:master Jan 8, 2025
23 checks passed
@michaldudak michaldudak deleted the menu-checkboxitem-closing branch January 8, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colmtuite colmtuite colmtuite approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Menu] Clicking checkbox/radio items closes menu when defaultOpen
3 participants
@michaldudak @mui-bot @colmtuite