Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Remove deprecated mocha and karma test scripts and update readme #1289

Merged
merged 10 commits into from
Jan 8, 2025
Merged

[test] Remove deprecated mocha and karma test scripts and update readme #1289

merged 10 commits into from
Jan 8, 2025

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 6, 2025 •
edited
Loading

  • Removed the unused (and now broken) scripts that were used to run mocha and karma.
  • Updated the test readme to describe the current test infrastructure.
  • Removed mocha and karma dependencies
  • Removed code added to ensure compatibility with both mocha and vitest
  • Removed the need to cast globalThis to any when controlling animations

@michaldudak michaldudak requested a review from atomiks as a code owner January 6, 2025 09:54
@mui-bot
Copy link

mui-bot commented Jan 6, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-1289--base-ui.netlify.app/

Generated by 🚫 dangerJS against a56e8b0

@michaldudak michaldudak requested a review from colmtuite as a code owner January 6, 2025 13:09
@michaldudak michaldudak requested a review from mj12albert January 6, 2025 13:13
michaldudak
michaldudak commented Jan 8, 2025
View reviewed changes
.eslintrc.js
// matching the pattern of the test runner
'*.test.?(c|m)[jt]s?(x)',
],
rules: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from the monorepo config

@michaldudak michaldudak merged commit 9552903 into mui:master Jan 8, 2025
23 checks passed
@michaldudak michaldudak deleted the test-scripts-cleanup branch January 8, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks atomiks approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@mj12albert mj12albert Awaiting requested review from mj12albert

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @mui-bot @atomiks