Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Remove rehypeEmptyLines #1212

Merged
merged 1 commit into from
Dec 22, 2024
Merged

[docs-infra] Remove rehypeEmptyLines #1212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/src/syntax-highlighting/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { createHighlighter } from 'shiki';
import rehypePrettyCode from 'rehype-pretty-code';
import { rehypeEmptyLines } from './rehypeEmptyLines.mjs';
Copy link
Member

@oliviertassinari oliviertassinari Dec 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we should delete this file too? rehypeEmptyLines.mjs is orphan now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has some purpose, but I'm not sure what - Vlad knows. I kept it in case it'll be re-added soon with a fixed implementation. Since git history keeps it here, it's not crucial to be kept around though.

import { rehypeInlineCode } from './rehypeInlineCode.mjs';
import { rehypePrettierIgnore } from './rehypePrettierIgnore.mjs';
import { rehypeJsxExpressions } from './rehypeJsxExpressions.mjs';
Expand Down Expand Up @@ -349,7 +348,6 @@ export const rehypeSyntaxHighlighting = [
defaultLang: 'tsx',
},
],
rehypeEmptyLines,
rehypePrettierIgnore,
rehypeJsxExpressions,
rehypeInlineCode,
Expand Down
Loading