-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Enable stylelint on CSS files #1184
base: master
Are you sure you want to change the base?
Conversation
--color-gray-700: oklch(92% 1.125% 264 / 80%); | ||
--color-gray-800: oklch(92% 1.125% 264 / 80%); | ||
--color-gray-800: oklch(93% 0.875% 264 / 85%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated value, seems wrong
Netlify deploy preview |
f7bbdc6
to
c686b2c
Compare
I'd disable the following rules:
And autofix all the remaining violations. |
As a follow up PR though, no? First goal here is to avoid the count to increase. To note that the first one can come from https://github.com/mui/material-ui/pull/44874/files#diff-2633572b1eb62578838877abeb39ff8053af5fa47a1a731129b889db37e59610R15 if we merge this. And the second one, we could add it to the monorepo config as I guess it's relevant for everyone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, could be a follow-up, I don't mind.
I noticed we didn't lint the .css files after my IDE reported issues opening them (using https://marketplace.visualstudio.com/items?itemName=stylelint.vscode-stylelint). It seems that we should start to lint those. There are too many rules to fix for me to make sense to do it, but I went with the simplest, quick win path:
I think next we could: