Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Fix support tier-1 flow regression #1149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 17, 2024

I have noticed this from #1148. The support flow seems to have had a couple of problems with #985. This PR aims to go after 1.

On using issue templates (now in Base UI, React, Tailwind CSS) vs. issue forms (Next.js, React Aria). I'm biased for issue forms, since mui/mui-x#2468. But happy either way. It feels like once we become tired of developers opening issues without respecting what we ask for, we will naturally land on issue forms.

@oliviertassinari oliviertassinari added the scope: infra Org infrastructure work going on behind the scenes label Dec 17, 2024
@flaviendelangle
Copy link
Member

We no longer have the "Search keywords". Added in mui/mui-x#10375 because it started to be really hard to find duplicate issues

I suspect it has been removed after https://mui-org.slack.com/archives/C02P87NQLJC/p1733997960666959

@mui-bot
Copy link

mui-bot commented Dec 17, 2024

Netlify deploy preview

https://deploy-preview-1149--base-ui.netlify.app/

Generated by 🚫 dangerJS against 5851c67

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have the labels been removed in the first place? And shouldn't we also add the default labels, like bug, feature to the respective templates as well? 🤔

@@ -1,6 +1,7 @@
---
name: 'Bug report'
about: 'File a bug report.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'bug 🐛']

@@ -1,6 +1,7 @@
---
name: 'Feature request'
about: 'Suggest a new component or an enhancement for an existing component.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'new feature']

@@ -1,6 +1,7 @@
---
name: 'Get help'
about: 'Ask a question.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'support: question']

@@ -1,6 +1,7 @@
---
name: 'Docs feedback'
about: 'Help us improve Base UI documentation.'
labels: ['status: waiting for maintainer']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
labels: ['status: waiting for maintainer']
labels: ['status: waiting for maintainer', 'support: docs-feedback']

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 28, 2024

Shouldn't we also add the default labels, like bug, feature to the respective templates as well? 🤔

@michelengelen Only MUI X repository has them so far.

Per mui/mui-x#13954 (comment), I don't know. We want to be able to trust that the labels are accurate (for analytics, etc. use cases), but these two things are not the same thing:

  • A user added the label, and the maintainer made the effort to check and correct the labels. (I would maybe trust at 50%)
  • There is nothing, a maintainer made the effort to add the right labels. (I would maybe trust at 90%)

So overall, I would see the right move as (#recommendation):

Now, happy either way, the goal being to:

  1. Can we have the equivalent for issues: https://www.notion.so/mui-org/KPIs-Product-165cbfe7b66080ddb7a3f306759f1b9a?pvs=4#165cbfe7b6608020b420c0d295f65d32. So we can make roadmap decision on, we need to fix more bug, regression, etc. based on product feedback.
  2. We can more rapidly find duplicate work and connect the dots (when you have 10,000 issues, which if Base UI becomes a success would 99% likely have, e.g. an autocomplete would already give us 3,000 issues https://github.com/JedWatson/react-select/issues?q=is%3Aissue+is%3Aclosed, a dialog, a carousel 5,000 issues https://github.com/nolimits4web/swiper/issues?q=is%3Aissue+is%3Aclosed, etc.)
  3. Balance 1. with having maintainers spending as little time as really needed labeling issues.

@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Dec 28, 2024
@michelengelen
Copy link
Member

  • A user added the label, and the maintainer made the effort to check and correct the labels. (I would maybe trust at 50%)

Users are not allowed to add labels to issues, so all labels are from maintainers. I guess this is to make sure that the labels are in fact accurate to a certain degree.

  • There is nothing, a maintainer made the effort to add the right labels. (I would maybe trust at 90%)

So overall, I would see the right move as (#recommendation):

We can do that ... i just wanted to reduce the friction on initial triage a bit.

This is potentially hard to do right. We can use the approach outlined in the linked issue, but the accuracy of the assigned labels might still be off. Thinking about this it could decrease friction as well, so maybe worth a shot, no?

On the other hand this would potentially already cut into the same corner, so the "right" action could be removing the initial labels ('bug', etc.) from the issue template and replace this with the mentioned GH action.

@colmtuite
Copy link
Contributor

The problem with default labels is that users will often open an issue via the incorrect template. Happy to add the "waiting for maintainer" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants