-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Fix support tier-1 flow regression #1149
base: master
Are you sure you want to change the base?
[infra] Fix support tier-1 flow regression #1149
Conversation
I suspect it has been removed after https://mui-org.slack.com/archives/C02P87NQLJC/p1733997960666959 |
Netlify deploy preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have the labels been removed in the first place? And shouldn't we also add the default labels, like bug, feature to the respective templates as well? 🤔
@@ -1,6 +1,7 @@ | |||
--- | |||
name: 'Bug report' | |||
about: 'File a bug report.' | |||
labels: ['status: waiting for maintainer'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labels: ['status: waiting for maintainer'] | |
labels: ['status: waiting for maintainer', 'bug 🐛'] |
@@ -1,6 +1,7 @@ | |||
--- | |||
name: 'Feature request' | |||
about: 'Suggest a new component or an enhancement for an existing component.' | |||
labels: ['status: waiting for maintainer'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labels: ['status: waiting for maintainer'] | |
labels: ['status: waiting for maintainer', 'new feature'] |
@@ -1,6 +1,7 @@ | |||
--- | |||
name: 'Get help' | |||
about: 'Ask a question.' | |||
labels: ['status: waiting for maintainer'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labels: ['status: waiting for maintainer'] | |
labels: ['status: waiting for maintainer', 'support: question'] |
@@ -1,6 +1,7 @@ | |||
--- | |||
name: 'Docs feedback' | |||
about: 'Help us improve Base UI documentation.' | |||
labels: ['status: waiting for maintainer'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labels: ['status: waiting for maintainer'] | |
labels: ['status: waiting for maintainer', 'support: docs-feedback'] |
@michelengelen Only MUI X repository has them so far. Per mui/mui-x#13954 (comment), I don't know. We want to be able to trust that the labels are accurate (for analytics, etc. use cases), but these two things are not the same thing:
So overall, I would see the right move as (#recommendation):
Now, happy either way, the goal being to:
|
Users are not allowed to add labels to issues, so all labels are from maintainers. I guess this is to make sure that the labels are in fact accurate to a certain degree.
We can do that ... i just wanted to reduce the friction on initial triage a bit.
This is potentially hard to do right. We can use the approach outlined in the linked issue, but the accuracy of the assigned labels might still be off. Thinking about this it could decrease friction as well, so maybe worth a shot, no? On the other hand this would potentially already cut into the same corner, so the "right" action could be removing the initial labels ('bug', etc.) from the issue template and replace this with the mentioned GH action. |
The problem with default labels is that users will often open an issue via the incorrect template. Happy to add the "waiting for maintainer" label. |
I have noticed this from #1148. The support flow seems to have had a couple of problems with #985. This PR aims to go after 1.
status: waiting for maintainer
label back in. Similar workflow of the Rust team https://github.com/orgs/community/discussions/139935#discussioncomment-11594872@mui/envinfo
. [envinfo] Ask for output from envinfo in issues material-ui#23881On using issue templates (now in Base UI, React, Tailwind CSS) vs. issue forms (Next.js, React Aria). I'm biased for issue forms, since mui/mui-x#2468. But happy either way. It feels like once we become tired of developers opening issues without respecting what we ask for, we will naturally land on issue forms.