Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A complete rewrite which addresses DWARF relocations, DWO support, full holistic test against known good golden outputs #22

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
6c7e951
New tests based on golden wasm and sourcemap
mtolmacs Dec 2, 2023
3922934
Intermediate state of rewrite
mtolmacs Dec 3, 2023
dbec4c2
Refactored but still not compiling
mtolmacs Dec 4, 2023
ddc96a1
Compiling
mtolmacs Dec 5, 2023
d22afc3
Half compiles
mtolmacs Dec 5, 2023
962b1bd
Relocator type
mtolmacs Dec 5, 2023
c474ddd
No need to reference
mtolmacs Dec 6, 2023
2b73d9e
Everything compiles
mtolmacs Dec 6, 2023
ec46b2f
Small refactors
mtolmacs Dec 6, 2023
c9fd497
Dwarf handling refactor
mtolmacs Dec 6, 2023
51efc41
Loader turned into a feature
mtolmacs Dec 6, 2023
f1d39e9
Refactor
mtolmacs Dec 6, 2023
63a7421
Refactors
mtolmacs Dec 7, 2023
4eec173
Path now contains directory
mtolmacs Dec 8, 2023
cc35082
End sequence fix
mtolmacs Dec 9, 2023
5543f94
Position test adapted, but failing
mtolmacs Dec 9, 2023
940725d
Column fix for entries
mtolmacs Dec 10, 2023
6f9cd76
VSCode launch configuration
mtolmacs Dec 11, 2023
1aae8a6
Fixes in entry generation
mtolmacs Dec 11, 2023
0da7ba8
Test asset llvm-dwarfdump output added
mtolmacs Dec 11, 2023
53eb884
Bringing entry addresses closer to the golden image
mtolmacs Dec 11, 2023
2414210
Minimal path resolution issues compared to golden
mtolmacs Dec 11, 2023
878b190
Finally the entry retrival tests pass
mtolmacs Dec 11, 2023
2c0957e
Introducing thiserror
mtolmacs Dec 16, 2023
a9b9b8d
Fix some test- and Result-related issues
mtolmacs Mar 6, 2024
c680e6a
Refactored dwarf module
mtolmacs Mar 6, 2024
b3f5c7f
Rust 1.64 dependency and other fixes
mtolmacs Mar 6, 2024
83bcfe6
CI build fix
mtolmacs Mar 6, 2024
7fa61c1
Explicit lifetimes
mtolmacs Jan 4, 2025
5e0444b
Modernize dependencies
mtolmacs Jan 4, 2025
92a3b93
Merge branch 'main' into with_crates
mtolmacs Jan 4, 2025
df61391
Update MSRV to 1.76.0
mtolmacs Jan 4, 2025
91787f2
Fix formatting
mtolmacs Jan 4, 2025
ebe2521
More specific dep versions for -Zminimal-versions
mtolmacs Jan 4, 2025
25224ee
Remove ilog polyfill with MSRV bump
mtolmacs Jan 4, 2025
e3f9ff6
Reintroducing tests from main
mtolmacs Jan 4, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .clippy.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
msrv = "1.64.0" # MSRV
msrv = "1.76.0" # MSRV
disallowed-methods = [
{ path = "std::option::Option::map_or", reason = "use `map(..).unwrap_or(..)`" },
{ path = "std::option::Option::map_or_else", reason = "use `map(..).unwrap_or_else(..)`" },
{ path = "std::result::Result::map_or", reason = "use `map(..).unwrap_or(..)`" },
{ path = "std::result::Result::map_or_else", reason = "use `map(..).unwrap_or_else(..)`" },
]
]
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ updates:
- package-ecosystem: github-actions
directory: /
schedule:
interval: daily
interval: weekly
- package-ecosystem: cargo
directory: /
schedule:
interval: daily
interval: weekly
ignore:
- dependency-name: "*"
# patch and minor updates don't matter for libraries
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
# https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
strategy:
matrix:
msrv: [1.64.0] # 2021 edition requires 1.56
msrv: [1.76.0] # 2021 edition requires 1.56
name: ubuntu / ${{ matrix.msrv }}
steps:
- uses: actions/checkout@v4
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ target/

# Coverage report files
lcov.info

# macOS
.DS_Store
64 changes: 64 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "lldb",
"request": "launch",
"name": "Debug unit tests in library 'wasm2map'",
"cargo": {
"args": [
"test",
"--no-run",
"--lib",
"--package=wasm2map"
],
"filter": {
"name": "wasm2map",
"kind": "lib"
}
},
"args": [],
"cwd": "${workspaceFolder}"
},
{
"type": "lldb",
"request": "launch",
"name": "Debug executable 'cargo-wasm2map'",
"cargo": {
"args": [
"build",
"--bin=cargo-wasm2map",
"--package=cargo-wasm2map"
],
"filter": {
"name": "cargo-wasm2map",
"kind": "bin"
}
},
"args": [],
"cwd": "${workspaceFolder}"
},
{
"type": "lldb",
"request": "launch",
"name": "Debug unit tests in executable 'cargo-wasm2map'",
"cargo": {
"args": [
"test",
"--no-run",
"--bin=cargo-wasm2map",
"--package=cargo-wasm2map"
],
"filter": {
"name": "cargo-wasm2map",
"kind": "bin"
}
},
"args": [],
"cwd": "${workspaceFolder}"
}
]
}
Loading
Loading