Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtsi: add pinctrl #35

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

dtsi: add pinctrl #35

wants to merge 2 commits into from

Conversation

wonderfulShrineMaidenOfParadise
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise commented Aug 18, 2023 •
edited
Loading

Fixes #29

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the title dtsi: Rename &msmgpio -> &tlmm dtsi: Rename &msmgpio -> &tlmm and add pinctrl Aug 18, 2023
stephan-gh
stephan-gh reviewed Oct 10, 2023
View reviewed changes
dtsi.py Outdated Show resolved Hide resolved
dtsi.py Outdated Show resolved Hide resolved
dtsi.py
@@ -35,6 +77,10 @@ def generate_panel_dtsi(p: Panel, options: Options) -> None:
''')
f.write(f'''\
&mdss_dsi0 {{
pinctrl-0 = <&mdss_default>;
pinctrl-1 = <&mdss_sleep>;
pinctrl-names = "default", "sleep";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we also generate this if there is no reset in options.gpio. The reset gpio is usually there but this is not guaranteed. e.g. samsung-gtelwifiue in linux-panel-drivers.

dtsi.py Outdated Show resolved Hide resolved
dtsi.py Outdated Show resolved Hide resolved
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise marked this pull request as draft December 1, 2023 01:23
@wonderfulShrineMaidenOfParadise
Copy link
Contributor Author

Without a doubt, msmgpio has to be renamed to tlmm. I split the part into another PR #38

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the title dtsi: Rename &msmgpio -> &tlmm and add pinctrl dtsi: Add pinctrl Dec 1, 2023
@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise changed the title dtsi: Add pinctrl dtsi: add pinctrl Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephan-gh stephan-gh stephan-gh left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dtsi: add pinctrl
2 participants
@wonderfulShrineMaidenOfParadise @stephan-gh