Added validation issues in case file does not contain VRM extensions …

…at all
mrxz · Nov 7, 2024 · fcd5a0f · fcd5a0f
1 parent add5d45
commit fcd5a0f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/src/base/gltf.dart b/lib/src/base/gltf.dart
@@ -97,6 +97,15 @@ class Gltf extends GltfProperty {
 
     context.initExtensions(extensionsUsed, extensionsRequired);
 
+    // Verify that the file IS a VRM file.
+    if (!extensionsUsed.contains('VRMC_vrm')) {
+      if (extensionsUsed.contains('VRM')) {
+        context.addIssue(SemanticError.vrm0Extension, name: EXTENSIONS_USED);
+      } else {
+        context.addIssue(SemanticError.vrm1MissingVrmExtension, name: EXTENSIONS_USED);
+      }
+    }
+
     // Helper function for converting JSON array to List of proper glTF objects
     SafeList<T> toSafeList<T>(String name, FromMapFunction<T> fromMap) {
       if (!map.containsKey(name)) {

diff --git a/lib/src/errors.dart b/lib/src/errors.dart
@@ -556,6 +556,18 @@ class SemanticError extends IssueType {
           Severity.Information);
 
   // VRM specific semantic errors
+  static final SemanticError vrm0Extension = SemanticError._(
+      'VRM0_VRM_EXTENSION',
+      (args) =>
+          'VRM 0.0 extensions are not validated',
+      Severity.Warning);
+
+  static final SemanticError vrm1MissingVrmExtension = SemanticError._(
+      'VRM1_NO_VRM_EXTENSION',
+      (args) =>
+          'The VRMC_vrm extension is missing; this file is NOT a .vrm file.',
+      Severity.Error);
+
   static final SemanticError vrm1TextureTransformRotation = SemanticError._(
       'VRM1_TEXTURE_TRANSFORM_ROTATION',
       (args) =>