Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing export type notation for unsupported types #401

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

cmaster11
Copy link
Collaborator

@cmaster11 cmaster11 commented Dec 10, 2023

Previously, a definition like

export const TestSchema = Joi.function().meta({ className: 'Test' });

was exporting broken TS code:

(...args: any[]) => any;

It now exports:

export type Test = (...args: any[]) => any;

Note: this will conflict on merge with #400. I'll take care of it if merged. Probably one test will fail.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4366519) 98.69% compared to head (5bedda5) 98.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files           9        9           
  Lines         535      537    +2     
  Branches      206      207    +1     
=======================================
+ Hits          528      530    +2     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaster11
Copy link
Collaborator Author

@mrjono1 test fixed now :)

@mrjono1 mrjono1 merged commit 1a9476b into mrjono1:master Dec 11, 2023
4 checks passed
@cmaster11 cmaster11 deleted the export-unsupported-type branch December 11, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants