Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

Commit

Permalink
Fix pipenv vs poetry (#156)
Browse files Browse the repository at this point in the history
* update README.md because this project is not using pipenv but poetry
* alter poetry installation because `pip install poetry` can mess up
  currently installed packages.
  (see https://python-poetry.org/docs/#installing-with-pip)
* fix install.sh script (pipenv -> poetry)
* update github actions to install poetry properly
* fix CI/lint
  • Loading branch information
shenek authored Jun 10, 2020
1 parent 483f2f7 commit 6f086ea
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
with:
toolchain: nightly
override: true
components: rustfmt, clippy

- name: Lint with rustfmt
uses: actions-rs/cargo@v1
Expand Down Expand Up @@ -66,7 +67,8 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install poetry
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python
echo "::add-path::${HOME}/.poetry/bin"
poetry install
- name: Install latest nightly
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,11 @@ Just pick one of the open tickets. We can provide mentorship if you like. :smile

## Developer guide

This project uses [pipenv](https://docs.pipenv.org/) for managing the development environment. If you don't have it installed, run
This project uses [poetry](https://python-poetry.org/docs/) for managing the development environment. If you don't have it installed, run

```
pip install poetry
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python
export PATH="$HOME/.poetry/bin:$PATH"
```

The project requires the `nightly` version of Rust.
Expand Down
5 changes: 3 additions & 2 deletions ci/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ main() {
export PATH="$HOME/.cargo/bin:$PATH"
which rustc
rustc --version
pip install pipenv
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | python
source ~/.poetry/env
cargo install maturin
make install
pipenv graph
poetry show --tree
}

main

0 comments on commit 6f086ea

Please sign in to comment.